On Tue, Sep 01, 2015 at 10:21:32PM +0200, Egbert Eich wrote:
> drm_kms_helper_poll_enable() was converted to lock the mode_config
> mutex in commit 8c4ccc4ab6f64e859d4ff8d7c02c2ed2e956e07f
> ("drm/probe-helper: Grab mode_config.mutex in poll_init/enable").
>
> This disregarded the cases where this
Lukas Wunner writes:
> Hi Egbert,
>
> On Wed, Sep 02, 2015 at 12:10:19AM +0200, Egbert Eich wrote:
> > Lukas Wunner writes:
> > > On Tue, Sep 01, 2015 at 10:21:32PM +0200, Egbert Eich wrote:
> > > > drm_kms_helper_poll_enable() was converted to lock the mode_config
> > > > mutex in commi
Lukas Wunner writes:
>
> It seems DRM convention is to append _locked or _unlocked, e.g.:
> drm_fb_helper_restore_fbdev_mode_unlocked
> drm_gem_object_unreference_unlocked
>
Oh, I missed that.
Did you check what these functions actually do - and compare it to
what I try to achieve?
Egbert
Hi Egbert,
On Wed, Sep 02, 2015 at 12:10:19AM +0200, Egbert Eich wrote:
> Lukas Wunner writes:
> > On Tue, Sep 01, 2015 at 10:21:32PM +0200, Egbert Eich wrote:
> > > drm_kms_helper_poll_enable() was converted to lock the mode_config
> > > mutex in commit 8c4ccc4ab6f64e859d4ff8d7c02c2ed2e956e07f
Lukas Wunner writes:
> Hi Egbert,
>
> On Tue, Sep 01, 2015 at 10:21:32PM +0200, Egbert Eich wrote:
> > drm_kms_helper_poll_enable() was converted to lock the mode_config
> > mutex in commit 8c4ccc4ab6f64e859d4ff8d7c02c2ed2e956e07f
> > ("drm/probe-helper: Grab mode_config.mutex in poll_init/e
Hi Egbert,
On Tue, Sep 01, 2015 at 10:21:32PM +0200, Egbert Eich wrote:
> drm_kms_helper_poll_enable() was converted to lock the mode_config
> mutex in commit 8c4ccc4ab6f64e859d4ff8d7c02c2ed2e956e07f
> ("drm/probe-helper: Grab mode_config.mutex in poll_init/enable").
>
> This disregarded the case
drm_kms_helper_poll_enable() was converted to lock the mode_config
mutex in commit 8c4ccc4ab6f64e859d4ff8d7c02c2ed2e956e07f
("drm/probe-helper: Grab mode_config.mutex in poll_init/enable").
This disregarded the cases where this function is called from a context
where this mutex is already locked.