All 5 patches look ok to me, I didn't spot anything to comment about.
Reviewed-by: Juha-Pekka Heikkila
On 14.9.2023 14.38, Ville Syrjala wrote:
From: Ville Syrjälä
The 16k max plane stride limit seems to be originally from
i965gm, and no limit explicit limit has been specified since (g4x+).
On Fri, Sep 15, 2023 at 09:48:54AM -0700, Matt Roper wrote:
> On Thu, Sep 14, 2023 at 02:38:50PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > The 16k max plane stride limit seems to be originally from
> > i965gm, and no limit explicit limit has been specified since (g4x+).
>
> The
On Thu, Sep 14, 2023 at 02:38:50PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> The 16k max plane stride limit seems to be originally from
> i965gm, and no limit explicit limit has been specified since (g4x+).
There are maximum limits specified on the PLANE_STRIDE register pages
(bspec
Thanks Ville for the fix!
LGTM
Reviewed-by: Swati Sharma
On 14-Sep-23 5:08 PM, Ville Syrjala wrote:
From: Ville Syrjälä
The 16k max plane stride limit seems to be originally from
i965gm, and no limit explicit limit has been specified since (g4x+).
nitpick: "limit" seems to be extra here
From: Ville Syrjälä
The 16k max plane stride limit seems to be originally from
i965gm, and no limit explicit limit has been specified since (g4x+).
So let's assume the max plane stride itself is a suitable limit
also for the more recent FBC hardware.
In fact even for i965gm the max X-tiled strid
