Re: [Intel-gfx] [PATCH 1/5] drm/i915: Always pin the fence for scanout on gen2/3 and primary planes

2017-11-22 Thread Ville Syrjälä
On Fri, Nov 17, 2017 at 09:29:33AM -0800, Rodrigo Vivi wrote: > On Fri, Nov 17, 2017 at 01:21:35PM +, Ville Syrjälä wrote: > > On Thu, Nov 16, 2017 at 12:49:23PM -0800, Rodrigo Vivi wrote: > > > On Thu, Nov 16, 2017 at 07:14:47PM +, Ville Syrjala wrote: > > > > From: Ville Syrjälä

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Always pin the fence for scanout on gen2/3 and primary planes

2017-11-17 Thread Rodrigo Vivi
On Fri, Nov 17, 2017 at 01:21:35PM +, Ville Syrjälä wrote: > On Thu, Nov 16, 2017 at 12:49:23PM -0800, Rodrigo Vivi wrote: > > On Thu, Nov 16, 2017 at 07:14:47PM +, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > The current code is trying to be

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Always pin the fence for scanout on gen2/3 and primary planes

2017-11-17 Thread Ville Syrjälä
On Thu, Nov 16, 2017 at 12:49:23PM -0800, Rodrigo Vivi wrote: > On Thu, Nov 16, 2017 at 07:14:47PM +, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The current code is trying to be lazy with fences on scanout buffers. > > That looks broken for several

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Always pin the fence for scanout on gen2/3 and primary planes

2017-11-17 Thread Ville Syrjälä
On Thu, Nov 16, 2017 at 09:06:08PM +, Chris Wilson wrote: > Quoting Ville Syrjala (2017-11-16 19:14:47) > > From: Ville Syrjälä > > > > The current code is trying to be lazy with fences on scanout buffers. > > That looks broken for several reasons: > > * gen2/3

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Always pin the fence for scanout on gen2/3 and primary planes

2017-11-16 Thread Chris Wilson
Quoting Ville Syrjala (2017-11-16 19:14:47) > From: Ville Syrjälä > > The current code is trying to be lazy with fences on scanout buffers. > That looks broken for several reasons: > * gen2/3 always need a fence for tiled scanout Which it already gets. All

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Always pin the fence for scanout on gen2/3 and primary planes

2017-11-16 Thread Rodrigo Vivi
On Thu, Nov 16, 2017 at 07:14:47PM +, Ville Syrjala wrote: > From: Ville Syrjälä > > The current code is trying to be lazy with fences on scanout buffers. > That looks broken for several reasons: > * gen2/3 always need a fence for tiled scanout > * the unpin

[Intel-gfx] [PATCH 1/5] drm/i915: Always pin the fence for scanout on gen2/3 and primary planes

2017-11-16 Thread Ville Syrjala
From: Ville Syrjälä The current code is trying to be lazy with fences on scanout buffers. That looks broken for several reasons: * gen2/3 always need a fence for tiled scanout * the unpin doesn't know whether we pinned the fence or not so it may unpin something