Re: [Intel-gfx] [PATCH 1/5] drm/i915: Fix forcewake counts for gen8

2014-02-24 Thread Ben Widawsky
On Mon, Feb 24, 2014 at 01:27:09PM +0200, Ville Syrjälä wrote: > On Fri, Feb 21, 2014 at 11:38:48AM -0800, Ben Widawsky wrote: > > On Fri, Feb 21, 2014 at 05:31:59PM +0200, mika.kuopp...@intel.com wrote: > > > From: Mika Kuoppala > > > > > > Sometimes generic driver code gets forcewake explicitly

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Fix forcewake counts for gen8

2014-02-24 Thread Ville Syrjälä
On Fri, Feb 21, 2014 at 11:38:48AM -0800, Ben Widawsky wrote: > On Fri, Feb 21, 2014 at 05:31:59PM +0200, mika.kuopp...@intel.com wrote: > > From: Mika Kuoppala > > > > Sometimes generic driver code gets forcewake explicitly by > > gen6_gt_force_wake_get(), which check forcewake_count before acce

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Fix forcewake counts for gen8

2014-02-21 Thread Chris Wilson
On Fri, Feb 21, 2014 at 11:38:48AM -0800, Ben Widawsky wrote: > On Fri, Feb 21, 2014 at 05:31:59PM +0200, mika.kuopp...@intel.com wrote: > > From: Mika Kuoppala > > > > Sometimes generic driver code gets forcewake explicitly by > > gen6_gt_force_wake_get(), which check forcewake_count before acce

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Fix forcewake counts for gen8

2014-02-21 Thread Ben Widawsky
On Fri, Feb 21, 2014 at 11:38:48AM -0800, Ben Widawsky wrote: > On Fri, Feb 21, 2014 at 05:31:59PM +0200, mika.kuopp...@intel.com wrote: > > From: Mika Kuoppala > > > > Sometimes generic driver code gets forcewake explicitly by > > gen6_gt_force_wake_get(), which check forcewake_count before acce

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Fix forcewake counts for gen8

2014-02-21 Thread Ben Widawsky
On Fri, Feb 21, 2014 at 05:31:59PM +0200, mika.kuopp...@intel.com wrote: > From: Mika Kuoppala > > Sometimes generic driver code gets forcewake explicitly by > gen6_gt_force_wake_get(), which check forcewake_count before accessing > hardware. However the register access with gen8_write function a

[Intel-gfx] [PATCH 1/5] drm/i915: Fix forcewake counts for gen8

2014-02-21 Thread mika . kuoppala
From: Mika Kuoppala Sometimes generic driver code gets forcewake explicitly by gen6_gt_force_wake_get(), which check forcewake_count before accessing hardware. However the register access with gen8_write function access low level hw accessors directly, ignoring the forcewake_count. This leads to