Re: [Intel-gfx] [PATCH 1/6] drm/i915/gt: Protect signaler walk with RCU

2020-02-20 Thread Matthew Auld
On 20/02/2020 12:52, Chris Wilson wrote: Quoting Matthew Auld (2020-02-20 12:47:28) On 20/02/2020 07:50, Chris Wilson wrote: While we know that the waiters cannot disappear as we walk our list (only that they might be added), the same cannot be said for our signalers as they may be completed

Re: [Intel-gfx] [PATCH 1/6] drm/i915/gt: Protect signaler walk with RCU

2020-02-20 Thread Chris Wilson
Quoting Matthew Auld (2020-02-20 12:47:28) > On 20/02/2020 07:50, Chris Wilson wrote: > > While we know that the waiters cannot disappear as we walk our list > > (only that they might be added), the same cannot be said for our > > signalers as they may be completed by the HW and retired as we

Re: [Intel-gfx] [PATCH 1/6] drm/i915/gt: Protect signaler walk with RCU

2020-02-20 Thread Matthew Auld
On 20/02/2020 07:50, Chris Wilson wrote: While we know that the waiters cannot disappear as we walk our list (only that they might be added), the same cannot be said for our signalers as they may be completed by the HW and retired as we process this request. Ergo we need to use rcu to protect

[Intel-gfx] [PATCH 1/6] drm/i915/gt: Protect signaler walk with RCU

2020-02-19 Thread Chris Wilson
While we know that the waiters cannot disappear as we walk our list (only that they might be added), the same cannot be said for our signalers as they may be completed by the HW and retired as we process this request. Ergo we need to use rcu to protect the list iteration and remember to mark up