[Intel-gfx] [PATCH 1/6] drm/i915: Introduce intel_ddi_dp_level.

2017-08-08 Thread Rodrigo Vivi
No functional changes. This only moves the DP level selection to a separated function that will be later used to organize better the vswing sequences. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_ddi.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Introduce intel_ddi_dp_level.

2017-08-09 Thread Jani Nikula
On Tue, 08 Aug 2017, Rodrigo Vivi wrote: > +static uint32_t intel_ddi_dp_level(struct intel_dp *intel_dp) Sorry to pick on specifically this patch when there continue to be offenders all over the place... but shouldn't we prefer the kernel types over standard C types? Not that checkpatch is an au

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Introduce intel_ddi_dp_level.

2017-08-09 Thread Vivi, Rodrigo
On Wed, 2017-08-09 at 15:20 +0300, Jani Nikula wrote: > On Tue, 08 Aug 2017, Rodrigo Vivi wrote: > > +static uint32_t intel_ddi_dp_level(struct intel_dp *intel_dp) > > Sorry to pick on specifically this patch when there continue to be > offenders all over the place... don't be sorry. I'm glad t