[Intel-gfx] [PATCH 1/8] drm/i915: Share the computation of ring size for RING_CTL register

2016-10-03 Thread Chris Wilson
Since both legacy and execlists want to poopulate the RING_CTL register, share the computation of the right bits for the ring->size. We can then stop masking errors and explicitly forbid them during creation! Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/i915_reg.h

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Share the computation of ring size for RING_CTL register

2016-10-03 Thread Chris Wilson
On Mon, Oct 03, 2016 at 01:52:39PM +0100, Chris Wilson wrote: > Since both legacy and execlists want to poopulate the RING_CTL register, > share the computation of the right bits for the ring->size. We can then > stop masking errors and explicitly forbid them during creation! > > Signed-off-by: Ch

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Share the computation of ring size for RING_CTL register

2016-10-03 Thread Mika Kuoppala
Chris Wilson writes: > Since both legacy and execlists want to poopulate the RING_CTL > register, A bit too graphic, lets switch to populate. Reviewed-by: Mika Kuoppala > share the computation of the right bits for the ring->size. We can then > stop masking errors and explicitly forbid them d

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Share the computation of ring size for RING_CTL register

2016-10-04 Thread Mika Kuoppala
Chris Wilson writes: > On Mon, Oct 03, 2016 at 01:52:39PM +0100, Chris Wilson wrote: >> Since both legacy and execlists want to poopulate the RING_CTL register, >> share the computation of the right bits for the ring->size. We can then >> stop masking errors and explicitly forbid them during crea