[Intel-gfx] [PATCH 1/9] drm/i915: Consolidate binding parameters into flags

2014-01-27 Thread Daniel Vetter
Anything more than just one bool parameter is just a pain to read, symbolic constants are much better. Split out from Chris' vma-binding rework patch. Cc: Chris Wilson Cc: Ben Widawsky Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h| 15 drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Consolidate binding parameters into flags

2014-01-27 Thread Chris Wilson
On Mon, Jan 27, 2014 at 07:10:51PM +0100, Daniel Vetter wrote: > Anything more than just one bool parameter is just a pain to read, > symbolic constants are much better. This patch introduces PIN_GLOBAL which is required for ggtt_pin to remain correct with the flag changes in the later patches, bu

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Consolidate binding parameters into flags

2014-01-27 Thread Daniel Vetter
On Mon, Jan 27, 2014 at 09:47:12PM +, Chris Wilson wrote: > On Mon, Jan 27, 2014 at 07:10:51PM +0100, Daniel Vetter wrote: > > Anything more than just one bool parameter is just a pain to read, > > symbolic constants are much better. > > This patch introduces PIN_GLOBAL which is required for g