Re: [Intel-gfx] [PATCH 10/11] drm/i915/guc: Skip interrupt enabling if logging is already enabled

2017-10-21 Thread Sagar Arun Kamble
On 10/19/2017 4:01 PM, Tvrtko Ursulin wrote: On 18/10/2017 07:47, Sagar Arun Kamble wrote: To balance the GuC interrupt references we don't allow enabling interrupts If logging was enabled earlier with different verbosity. I've noticed in a couple of your previous commits words in the

Re: [Intel-gfx] [PATCH 10/11] drm/i915/guc: Skip interrupt enabling if logging is already enabled

2017-10-19 Thread Tvrtko Ursulin
On 18/10/2017 07:47, Sagar Arun Kamble wrote: To balance the GuC interrupt references we don't allow enabling interrupts If logging was enabled earlier with different verbosity. I've noticed in a couple of your previous commits words in the middle of sentences starting with upper case which

[Intel-gfx] [PATCH 10/11] drm/i915/guc: Skip interrupt enabling if logging is already enabled

2017-10-18 Thread Sagar Arun Kamble
To balance the GuC interrupt references we don't allow enabling interrupts If logging was enabled earlier with different verbosity. We allow request to change log parameters to be sent to GuC though as user may want to just update the verbosity level at runtime. Signed-off-by: Sagar Arun Kamble