Re: [Intel-gfx] [PATCH 10/12] drm/i915: Update link training automated test function for Displayport compliance

2014-07-22 Thread Jesse Barnes
On Tue, 22 Jul 2014 22:44:54 +0200 Daniel Vetter wrote: > On Tue, Jul 22, 2014 at 10:40 PM, Jesse Barnes > wrote: > >> > + /* Set link rate directly */ > >> > + intel_dp->link_bw = rxdata[0]; > >> > + /* Preserve 7:5 when setting lane count */ > >> > + intel_dp->lane_count &= 0xE0; > >>

Re: [Intel-gfx] [PATCH 10/12] drm/i915: Update link training automated test function for Displayport compliance

2014-07-22 Thread Daniel Vetter
On Tue, Jul 22, 2014 at 10:40 PM, Jesse Barnes wrote: >> > + /* Set link rate directly */ >> > + intel_dp->link_bw = rxdata[0]; >> > + /* Preserve 7:5 when setting lane count */ >> > + intel_dp->lane_count &= 0xE0; >> > + intel_dp->lane_count |= rxdata[1]; >> >> This won't work - if you

Re: [Intel-gfx] [PATCH 10/12] drm/i915: Update link training automated test function for Displayport compliance

2014-07-22 Thread Jesse Barnes
On Tue, 22 Jul 2014 08:15:30 +0200 Daniel Vetter wrote: > On Mon, Jul 14, 2014 at 12:10:45PM -0700, Todd Previte wrote: > > Implements basic link training functionality for Displayport automated > > compliance > > testing. > > > > Signed-off-by: Todd Previte > > --- > > drivers/gpu/drm/i915/i

Re: [Intel-gfx] [PATCH 10/12] drm/i915: Update link training automated test function for Displayport compliance

2014-07-21 Thread Daniel Vetter
On Mon, Jul 14, 2014 at 12:10:45PM -0700, Todd Previte wrote: > Implements basic link training functionality for Displayport automated > compliance > testing. > > Signed-off-by: Todd Previte > --- > drivers/gpu/drm/i915/intel_dp.c | 47 > + > 1 file chan

[Intel-gfx] [PATCH 10/12] drm/i915: Update link training automated test function for Displayport compliance

2014-07-14 Thread Todd Previte
Implements basic link training functionality for Displayport automated compliance testing. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 47 + 1 file changed, 47 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu