Re: [Intel-gfx] [PATCH 10/36] drm/i915: Replace pcu_lock with sb_lock

2018-04-09 Thread Chris Wilson
Quoting Sagar Arun Kamble (2018-03-15 12:06:57) > On 3/14/2018 3:07 PM, Chris Wilson wrote: > > struct intel_rps { > > + struct mutex lock; > > + > I think this lock can now become part of struct intel_gt_pm. Maybe, haven't decided yet. Anything but rps is so infrequent as not to really matt

Re: [Intel-gfx] [PATCH 10/36] drm/i915: Replace pcu_lock with sb_lock

2018-03-15 Thread Sagar Arun Kamble
On 3/14/2018 3:07 PM, Chris Wilson wrote: We now have two locks for sideband access. The general one covering sideband access across all generation, sb_lock, and a specific one covering sideband access via the punit on vlv/chv. After lifting the sb_lock around the punit into the callers, the pc

[Intel-gfx] [PATCH 10/36] drm/i915: Replace pcu_lock with sb_lock

2018-03-14 Thread Chris Wilson
We now have two locks for sideband access. The general one covering sideband access across all generation, sb_lock, and a specific one covering sideband access via the punit on vlv/chv. After lifting the sb_lock around the punit into the callers, the pcu_lock is now redudant and can be separated fr