Re: [Intel-gfx] [PATCH 10/9] drm/i915/bdw: Kill ppgtt->num_pt_pages

2014-03-04 Thread Daniel Vetter
On Mon, Feb 24, 2014 at 07:17:02PM +0200, Imre Deak wrote: > On Fri, 2014-02-21 at 13:06 -0800, Ben Widawsky wrote: > > With the original PPGTT implementation if the number of PDPs was not a > > power of two, the number of pages for the page tables would end up being > > rounded up. The code actual

Re: [Intel-gfx] [PATCH 10/9] drm/i915/bdw: Kill ppgtt->num_pt_pages

2014-02-24 Thread Imre Deak
On Fri, 2014-02-21 at 13:06 -0800, Ben Widawsky wrote: > With the original PPGTT implementation if the number of PDPs was not a > power of two, the number of pages for the page tables would end up being > rounded up. The code actually had a bug here afaict, but this is a > theoretical bug as I don'

[Intel-gfx] [PATCH 10/9] drm/i915/bdw: Kill ppgtt->num_pt_pages

2014-02-21 Thread Ben Widawsky
With the original PPGTT implementation if the number of PDPs was not a power of two, the number of pages for the page tables would end up being rounded up. The code actually had a bug here afaict, but this is a theoretical bug as I don't believe this can actually occur with the current code/HW.. W