Re: [Intel-gfx] [PATCH 11/19] drm/i915: interrupt & vblank support for Ivy Bridge

2011-06-28 Thread Chris Wilson
On Thu, 28 Apr 2011 15:12:57 -0700, Jesse Barnes wrote: > Add new interrupt handling functions for Ivy Bridge. There's a slight discrepancy here: > + if (IS_IVYBRIDGE(dev)) { > + /* Share pre & uninstall handlers with ILK/SNB */ > + dev->driver->irq_handler = ivybrid

Re: [Intel-gfx] [PATCH 11/19] drm/i915: interrupt & vblank support for Ivy Bridge

2011-04-28 Thread Keith Packard
On Thu, 28 Apr 2011 15:12:57 -0700, Jesse Barnes wrote: > - if (IS_G4X(dev) || IS_GEN5(dev) || IS_GEN6(dev)) { > + if (IS_G4X(dev) || IS_GEN5(dev) || IS_GEN6(dev) || IS_IVYBRIDGE(dev)) { IS_G4X || gen >= 5 ? Otherwise, this looks good (seems like it's just bit shuffling from SNB, right

[Intel-gfx] [PATCH 11/19] drm/i915: interrupt & vblank support for Ivy Bridge

2011-04-28 Thread Jesse Barnes
Add new interrupt handling functions for Ivy Bridge. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_dma.c | 12 +++- drivers/gpu/drm/i915/i915_drv.h |7 ++ drivers/gpu/drm/i915/i915_irq.c | 156 +++ drivers/gpu/drm/i915/i915_reg.h | 13 +++