Re: [Intel-gfx] [PATCH 112/190] drm/i915: Move obj->active:5 to obj->flags

2016-03-24 Thread David Weinehall
On Mon, Jan 11, 2016 at 10:44:56AM +, Chris Wilson wrote: > We are motivated to avoid using a bitfield for obj->active for a couple > of reasons. Firstly, we wish to document our lockless read of obj->active > using READ_ONCE inside i915_gem_busy_ioctl() and that requires an > integral type (i.

[Intel-gfx] [PATCH 112/190] drm/i915: Move obj->active:5 to obj->flags

2016-01-11 Thread Chris Wilson
We are motivated to avoid using a bitfield for obj->active for a couple of reasons. Firstly, we wish to document our lockless read of obj->active using READ_ONCE inside i915_gem_busy_ioctl() and that requires an integral type (i.e. not a bitfield). Secondly, gcc produces abysmal code when presented