[Intel-gfx] [PATCH 12/37] drm/i915: add SBI registers

2012-03-21 Thread Eugeni Dodonov
Those are responsible for the Sideband Interface programming. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_reg.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 0af47b4..4ee8965 100644 --- a/

Re: [Intel-gfx] [PATCH 12/37] drm/i915: add SBI registers

2012-03-26 Thread Rodrigo Vivi
* indentation Reviewed-by: Rodrigo Vivi On Wed, Mar 21, 2012 at 10:09 PM, Eugeni Dodonov wrote: > Those are responsible for the Sideband Interface programming. > > Signed-off-by: Eugeni Dodonov > --- >  drivers/gpu/drm/i915/i915_reg.h |   10 ++ >  1 file changed, 10 insertions(+) > > di

Re: [Intel-gfx] [PATCH 12/37] drm/i915: add SBI registers

2012-03-26 Thread Rodrigo Vivi
Ops, actually I'm in doubt about this one, for me: SBI_RESPONSE should be (0x0<<1) SBI_READY should be(0x0<<0) let's double check this togheter, otherwise: Reviewed-by: Rodrigo Vivi On Mon, Mar 26, 2012 at 2:40 PM, Rodrigo Vivi wrote: > * indentation > Reviewed-by: Rodrigo Vivi > > On

Re: [Intel-gfx] [PATCH 12/37] drm/i915: add SBI registers

2012-03-26 Thread Rodrigo Vivi
and here can be SBI_BUSY 0x1<<0 and SBI_RESPONSE_UNSUCCESSFUL 0x1<<1 On Mon, Mar 26, 2012 at 2:48 PM, Rodrigo Vivi wrote: > Ops, actually I'm in doubt about this one, for me: > > SBI_RESPONSE  should be  (0x0<<1) > SBI_READY  should be    (0x0<<0) > > let's double check this togheter, otherwise: