Re: [Intel-gfx] [PATCH 13/14] drm/i915: Use intel_dp->DP in eDP PLL setup

2015-11-10 Thread Jani Nikula
On Fri, 30 Oct 2015, Ville Syrjälä wrote: > On Fri, Oct 30, 2015 at 05:00:42PM +0100, Daniel Vetter wrote: >> On Thu, Oct 29, 2015 at 09:26:02PM +0200, ville.syrj...@linux.intel.com >> wrote: >> > From: Ville Syrjälä >> > >> > Use intel_dp->DP in the eDP PLL setup, instead of doing RMWs. >> >

Re: [Intel-gfx] [PATCH 13/14] drm/i915: Use intel_dp->DP in eDP PLL setup

2015-10-30 Thread Ville Syrjälä
On Fri, Oct 30, 2015 at 05:00:42PM +0100, Daniel Vetter wrote: > On Thu, Oct 29, 2015 at 09:26:02PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Use intel_dp->DP in the eDP PLL setup, instead of doing RMWs. > > > > To do this we need to move DP_AUDIO_OUTPUT_ENABLE

Re: [Intel-gfx] [PATCH 13/14] drm/i915: Use intel_dp->DP in eDP PLL setup

2015-10-30 Thread Daniel Vetter
On Thu, Oct 29, 2015 at 09:26:02PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Use intel_dp->DP in the eDP PLL setup, instead of doing RMWs. > > To do this we need to move DP_AUDIO_OUTPUT_ENABLE setup to happen later, > so that we don't enable audio accidentally while c

[Intel-gfx] [PATCH 13/14] drm/i915: Use intel_dp->DP in eDP PLL setup

2015-10-29 Thread ville . syrjala
From: Ville Syrjälä Use intel_dp->DP in the eDP PLL setup, instead of doing RMWs. To do this we need to move DP_AUDIO_OUTPUT_ENABLE setup to happen later, so that we don't enable audio accidentally while configuring the PLL. Also intel_dp_link_down() must be made to update intel_dp->DP so that