Re: [Intel-gfx] [PATCH 13/21] drm/i915/gem: Add an intermediate proto_context struct

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 8:02 AM Daniel Vetter wrote: > > The commit introducing a new data structure really should have a solid > intro in the commit message about. Please cover > > - that ctx really should be immutable, safe for exceptions like priority > > - that unfortunately we butchered the u

Re: [Intel-gfx] [PATCH 13/21] drm/i915/gem: Add an intermediate proto_context struct

2021-04-29 Thread Daniel Vetter
The commit introducing a new data structure really should have a solid intro in the commit message about. Please cover - that ctx really should be immutable, safe for exceptions like priority - that unfortunately we butchered the uapi with setparam and sharing setparams between create_ext and s

[Intel-gfx] [PATCH 13/21] drm/i915/gem: Add an intermediate proto_context struct

2021-04-23 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 143 ++ .../gpu/drm/i915/gem/i915_gem_context_types.h | 21 +++ .../gpu/drm/i915/gem/selftests/mock_context.c | 16 +- 3 files changed, 150 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/