Re: [Intel-gfx] [PATCH 13/21] drm/i915: Pull i915_vma_pin under the vm->mutex

2019-09-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-09-19 14:37:01) > > On 17/09/2019 19:56, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-09-17 13:37:55) > >> On 02/09/2019 05:02, Chris Wilson wrote: > >>> +void i915_active_set_exclusive(struct i915_active *ref, struct dma_fence > >>> *f) > >>> +{ > >>> +

Re: [Intel-gfx] [PATCH 13/21] drm/i915: Pull i915_vma_pin under the vm->mutex

2019-09-19 Thread Tvrtko Ursulin
On 17/09/2019 19:56, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-09-17 13:37:55) On 02/09/2019 05:02, Chris Wilson wrote: diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c index 82db2b783123..9a8c307c5aeb 100644 ---

Re: [Intel-gfx] [PATCH 13/21] drm/i915: Pull i915_vma_pin under the vm->mutex

2019-09-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-09-17 13:37:55) > On 02/09/2019 05:02, Chris Wilson wrote: > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c > > b/drivers/gpu/drm/i915/gem/i915_gem_mman.c > > index 82db2b783123..9a8c307c5aeb 100644 > > --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c > > +++

Re: [Intel-gfx] [PATCH 13/21] drm/i915: Pull i915_vma_pin under the vm->mutex

2019-09-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-09-16 11:13:23) > > On 02/09/2019 05:02, Chris Wilson wrote: > > Replace the struct_mutex requirement for pinning the i915_vma with the > > local vm->mutex instead. Note that the vm->mutex is tainted by the > > shrinker (we require unbinding from inside fs-reclaim)

[Intel-gfx] [PATCH 13/21] drm/i915: Pull i915_vma_pin under the vm->mutex

2019-09-01 Thread Chris Wilson
Replace the struct_mutex requirement for pinning the i915_vma with the local vm->mutex instead. Note that the vm->mutex is tainted by the shrinker (we require unbinding from inside fs-reclaim) and so we cannot allocate while holding that mutex. Instead we have to preallocate workers to do allocate

[Intel-gfx] [PATCH 13/21] drm/i915: Pull i915_vma_pin under the vm->mutex

2019-08-30 Thread Chris Wilson
Replace the struct_mutex requirement for pinning the i915_vma with the local vm->mutex instead. Note that the vm->mutex is tainted by the shrinker (we require unbinding from inside fs-reclaim) and so we cannot allocate while holding that mutex. Instead we have to preallocate workers to do allocate