[Intel-gfx] [PATCH 14/14] drm/i915: inline enable/disable_irq into ring->get/put_irq

2012-04-11 Thread Daniel Vetter
Now that these are properly refactored this additional indirection doesn't really buy us anything but confusion. Hence inline them. This duplicates the ironlake gt enable/disable code snippet, but we've already separate ilk from gen6+ gt irq in i915_irq.c, so I think this makes more sense. Signed

Re: [Intel-gfx] [PATCH 14/14] drm/i915: inline enable/disable_irq into ring->get/put_irq

2012-04-12 Thread Ben Widawsky
On Wed, 11 Apr 2012 22:12:59 +0200 Daniel Vetter wrote: > Now that these are properly refactored this additional indirection > doesn't really buy us anything but confusion. Hence inline them. > > This duplicates the ironlake gt enable/disable code snippet, but we've > already separate ilk from g

Re: [Intel-gfx] [PATCH 14/14] drm/i915: inline enable/disable_irq into ring->get/put_irq

2012-04-13 Thread Daniel Vetter
On Thu, Apr 12, 2012 at 06:03:30PM -0700, Ben Widawsky wrote: > On Wed, 11 Apr 2012 22:12:59 +0200 > Daniel Vetter wrote: > > > Now that these are properly refactored this additional indirection > > doesn't really buy us anything but confusion. Hence inline them. > > > > This duplicates the iron

Re: [Intel-gfx] [PATCH 14/14] drm/i915: inline enable/disable_irq into ring->get/put_irq

2012-04-13 Thread Chris Wilson
On Fri, 13 Apr 2012 11:13:53 +0200, Daniel Vetter wrote: > On Thu, Apr 12, 2012 at 06:03:30PM -0700, Ben Widawsky wrote: > > On Wed, 11 Apr 2012 22:12:59 +0200 > > Daniel Vetter wrote: > > > > > Now that these are properly refactored this additional indirection > > > doesn't really buy us anythi