Re: [Intel-gfx] [PATCH 14/14] drm/vmwgfx: Add FIXME comments for customer page_flip handlers

2018-09-04 Thread Daniel Vetter
On Tue, Sep 4, 2018 at 3:45 PM, Thomas Hellstrom wrote: > On 09/03/2018 06:54 PM, Daniel Vetter wrote: >> >> The idea behind allowing drivers to override legacy ioctls (instead of >> using the generic implementations unconditionally) is to handle bugs >> in old driver-specific userspace. Like

Re: [Intel-gfx] [PATCH 14/14] drm/vmwgfx: Add FIXME comments for customer page_flip handlers

2018-09-04 Thread Thomas Hellstrom
On 09/03/2018 06:54 PM, Daniel Vetter wrote: The idea behind allowing drivers to override legacy ioctls (instead of using the generic implementations unconditionally) is to handle bugs in old driver-specific userspace. Like e.g. vmw_kms_set_config does, to work around some vmwgfx userspace not

[Intel-gfx] [PATCH 14/14] drm/vmwgfx: Add FIXME comments for customer page_flip handlers

2018-09-03 Thread Daniel Vetter
The idea behind allowing drivers to override legacy ioctls (instead of using the generic implementations unconditionally) is to handle bugs in old driver-specific userspace. Like e.g. vmw_kms_set_config does, to work around some vmwgfx userspace not clearing its ioctl structs properly. But you