Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-14 Thread Sivakumar Thulasimani
Thanks for the update Mika. The issue will be that audio plays faster or slower than normal. i.e it will be 1x or 1x. can you confirm if audible sound plays after CD Clock change at 1x speed ? regards, Sivakumar On 4/14/2015 12:06 PM, Mika Kahola wrote: I tested this patch with the audio in

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-14 Thread Mika Kahola
With pink noise you can't tell if the audio is played faster or slower. I tested this by playing ITU speech codec test sample aplay --device=plughw:0,7 male.wav and audio played back on 1x speed. Cheers, Mika On Tue, 2015-04-14 at 12:27 +0530, Sivakumar Thulasimani wrote: Thanks for the

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-14 Thread Mika Kahola
I tested this patch with the audio in place. With this setup in my HSW machine I can hear the pink noise played back with DP-HDMI cable attatched. speaker-test -c 2 -r 48000 -F S16_LE -t pink --device=plughw:0,7 Cheers, Mika On Tue, 2015-04-07 at 14:06 +0530, Sivakumar Thulasimani wrote: where

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-14 Thread Sivakumar Thulasimani
Thanks for the confirmation, Mika :). then this change is fine not sure if it is still relevant but you can add rb if possible Reviewed-by: Sivakumar Thulasimani sivakumar.thulasim...@intel.com On 4/14/2015 12:36 PM, Mika Kahola wrote: With pink noise you can't tell if the audio is played

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-13 Thread Ville Syrjälä
On Mon, Apr 13, 2015 at 12:43:14PM +0300, Mika Kahola wrote: On Fri, 2015-04-10 at 16:10 +0200, Takashi Iwai wrote: At Fri, 10 Apr 2015 16:27:39 +0300, Mika Kahola wrote: On Thu, 2015-04-09 at 17:17 +0200, Takashi Iwai wrote: At Thu, 9 Apr 2015 15:51:27 +0200, Daniel Vetter

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-13 Thread Mika Kahola
On Fri, 2015-04-10 at 16:10 +0200, Takashi Iwai wrote: At Fri, 10 Apr 2015 16:27:39 +0300, Mika Kahola wrote: On Thu, 2015-04-09 at 17:17 +0200, Takashi Iwai wrote: At Thu, 9 Apr 2015 15:51:27 +0200, Daniel Vetter wrote: On Thu, Apr 09, 2015 at 04:41:26PM +0300, Mika Kahola

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-09 Thread Daniel Vetter
On Thu, Apr 09, 2015 at 04:41:26PM +0300, Mika Kahola wrote: On Thu, 2015-04-09 at 11:32 +0200, Daniel Vetter wrote: On Thu, Apr 09, 2015 at 10:24:24AM +0300, Mika Kahola wrote: I did some testing on audio part with HDMI-HDMI and DP-HDMI cables connected to my Haswell box. Before applying

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-09 Thread Daniel Vetter
On Thu, Apr 09, 2015 at 10:24:24AM +0300, Mika Kahola wrote: I did some testing on audio part with HDMI-HDMI and DP-HDMI cables connected to my Haswell box. Before applying the patch I tested as a reference with the latest -nightly (04-08-2015), 4.0-rc7. Unfortunately, I failed to get any

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-09 Thread Takashi Iwai
At Thu, 9 Apr 2015 15:51:27 +0200, Daniel Vetter wrote: On Thu, Apr 09, 2015 at 04:41:26PM +0300, Mika Kahola wrote: On Thu, 2015-04-09 at 11:32 +0200, Daniel Vetter wrote: On Thu, Apr 09, 2015 at 10:24:24AM +0300, Mika Kahola wrote: I did some testing on audio part with HDMI-HDMI and

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-09 Thread Mika Kahola
I did some testing on audio part with HDMI-HDMI and DP-HDMI cables connected to my Haswell box. Before applying the patch I tested as a reference with the latest -nightly (04-08-2015), 4.0-rc7. Unfortunately, I failed to get any audio over HDMI cable. For a reference I tested with the very same

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-09 Thread Mika Kahola
On Thu, 2015-04-09 at 11:32 +0200, Daniel Vetter wrote: On Thu, Apr 09, 2015 at 10:24:24AM +0300, Mika Kahola wrote: I did some testing on audio part with HDMI-HDMI and DP-HDMI cables connected to my Haswell box. Before applying the patch I tested as a reference with the latest -nightly

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-07 Thread Ville Syrjälä
On Tue, Apr 07, 2015 at 12:33:40PM +0530, Sivakumar Thulasimani wrote: sorry if i am missing something, HSW and BDW requires display audio controller to be updated with new values once CD clock is modified. how is this accomplished here ? I'm hoping the audio driver will query the cdclk

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-07 Thread Ville Syrjälä
On Tue, Apr 07, 2015 at 11:57:23AM +0530, Sivakumar Thulasimani wrote: On 3/31/2015 4:44 PM, Mika Kahola wrote: Implement support for changing the cdclk frequency during runtime on HSW. VLV/CHV already have support for this, so we can follow their example for the most part. Only the

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-07 Thread Sivakumar Thulasimani
where can i check this (audio driver) ? since there was no need for them to check CD clock value till now i don't think they will be doing it. also this needs to be changed in Display Audio controller, so not sure if audio driver has access to it in the first place. will be good to confirm

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-07 Thread Sivakumar Thulasimani
On 3/31/2015 4:44 PM, Mika Kahola wrote: Implement support for changing the cdclk frequency during runtime on HSW. VLV/CHV already have support for this, so we can follow their example for the most part. Only the actual hardware programming differs, the rest is pretty much the same. The pipe

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-07 Thread Sivakumar Thulasimani
sorry if i am missing something, HSW and BDW requires display audio controller to be updated with new values once CD clock is modified. how is this accomplished here ? regards, Sivakumar On 4/7/2015 11:57 AM, Sivakumar Thulasimani wrote: On 3/31/2015 4:44 PM, Mika Kahola wrote: Implement

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-07 Thread Mika Kahola
Definitely a good idea to check the audio part as well if there is a doubt that by changing CD clock the audio would fail. I can check this and I'll get back once I have the results. Cheers, Mika On Tue, Apr 07, 2015 at 02:06:50PM +0530, Sivakumar Thulasimani wrote: where can i check this

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-07 Thread Daniel Vetter
On Tue, Apr 07, 2015 at 12:29:25PM +0300, Mika Kahola wrote: Definitely a good idea to check the audio part as well if there is a doubt that by changing CD clock the audio would fail. I can check this and I'll get back once I have the results. We force a full modeset, which should result in an

[Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-03-31 Thread Mika Kahola
Implement support for changing the cdclk frequency during runtime on HSW. VLV/CHV already have support for this, so we can follow their example for the most part. Only the actual hardware programming differs, the rest is pretty much the same. The pipe pixel rate stuff is handled a bit differently