Re: [Intel-gfx] [PATCH 15/20] drm/i915/guc: Ensure H2G buffer updates visible before tail update

2021-06-04 Thread Daniel Vetter
On Thu, Jun 03, 2021 at 09:10:14AM -0700, Matthew Brost wrote: > On Thu, Jun 03, 2021 at 11:44:57AM +0200, Michal Wajdeczko wrote: > > > > > > On 03.06.2021 07:16, Matthew Brost wrote: > > > Ensure H2G buffer updates are visible before descriptor tail updates by > > > inserting a barrier between

Re: [Intel-gfx] [PATCH 15/20] drm/i915/guc: Ensure H2G buffer updates visible before tail update

2021-06-03 Thread Matthew Brost
On Thu, Jun 03, 2021 at 11:44:57AM +0200, Michal Wajdeczko wrote: > > > On 03.06.2021 07:16, Matthew Brost wrote: > > Ensure H2G buffer updates are visible before descriptor tail updates by > > inserting a barrier between the H2G buffer update and the tail. The > > barrier is simple wmb() for SME

Re: [Intel-gfx] [PATCH 15/20] drm/i915/guc: Ensure H2G buffer updates visible before tail update

2021-06-03 Thread Michal Wajdeczko
On 03.06.2021 07:16, Matthew Brost wrote: > Ensure H2G buffer updates are visible before descriptor tail updates by > inserting a barrier between the H2G buffer update and the tail. The > barrier is simple wmb() for SMEM and is register write for LMEM. This is > needed if more than 1 H2G can be

[Intel-gfx] [PATCH 15/20] drm/i915/guc: Ensure H2G buffer updates visible before tail update

2021-06-02 Thread Matthew Brost
Ensure H2G buffer updates are visible before descriptor tail updates by inserting a barrier between the H2G buffer update and the tail. The barrier is simple wmb() for SMEM and is register write for LMEM. This is needed if more than 1 H2G can be inflight at once. If this barrier is not inserted it