Re: [Intel-gfx] [PATCH 16/18] drm/i915: Remove duplicate golden render state init from execlists

2016-07-22 Thread Joonas Lahtinen
On to, 2016-07-21 at 17:37 +0100, Chris Wilson wrote: > On Thu, Jul 21, 2016 at 05:27:06PM +0100, Chris Wilson wrote: > > > > On Thu, Jul 21, 2016 at 05:18:17PM +0300, Joonas Lahtinen wrote: > > > > > > On ke, 2016-07-20 at 14:12 +0100, Chris Wilson wrote: > > > > > > > >  static const struct in

Re: [Intel-gfx] [PATCH 16/18] drm/i915: Remove duplicate golden render state init from execlists

2016-07-21 Thread Chris Wilson
On Thu, Jul 21, 2016 at 05:27:06PM +0100, Chris Wilson wrote: > On Thu, Jul 21, 2016 at 05:18:17PM +0300, Joonas Lahtinen wrote: > > On ke, 2016-07-20 at 14:12 +0100, Chris Wilson wrote: > > >  static const struct intel_renderstate_rodata * > > >  render_state_get_rodata(const int gen) > > >  { > >

Re: [Intel-gfx] [PATCH 16/18] drm/i915: Remove duplicate golden render state init from execlists

2016-07-21 Thread Chris Wilson
On Thu, Jul 21, 2016 at 05:18:17PM +0300, Joonas Lahtinen wrote: > On ke, 2016-07-20 at 14:12 +0100, Chris Wilson wrote: > >  static const struct intel_renderstate_rodata * > >  render_state_get_rodata(const int gen) > >  { > > @@ -51,6 +60,7 @@ static int render_state_init(struct render_state *so,

Re: [Intel-gfx] [PATCH 16/18] drm/i915: Remove duplicate golden render state init from execlists

2016-07-21 Thread Joonas Lahtinen
On ke, 2016-07-20 at 14:12 +0100, Chris Wilson wrote: >  static const struct intel_renderstate_rodata * >  render_state_get_rodata(const int gen) >  { > @@ -51,6 +60,7 @@ static int render_state_init(struct render_state *so, >   int ret; >   >   so->gen = INTEL_GEN(dev_priv); > + so->gg

[Intel-gfx] [PATCH 16/18] drm/i915: Remove duplicate golden render state init from execlists

2016-07-20 Thread Chris Wilson
Now that we use the same vfuncs for emitting the batch buffer in both execlists and legacy, the golden render state initialisation is identical between both. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_render_state.c | 23 +-- drivers/gpu/drm/i915/i915_gem_rende