Re: [Intel-gfx] [PATCH 17/41] drm/i915: Pass around sg_table to get_pages/put_pages backend

2016-10-17 Thread Chris Wilson
On Mon, Oct 17, 2016 at 02:51:01PM +0100, Tvrtko Ursulin wrote: > > On 17/10/2016 12:31, Chris Wilson wrote: > >On Mon, Oct 17, 2016 at 11:55:54AM +0100, Tvrtko Ursulin wrote: > >>On 14/10/2016 13:18, Chris Wilson wrote: > >>> static void > >>>-i915_gem_object_put_pages_gtt(struct

Re: [Intel-gfx] [PATCH 17/41] drm/i915: Pass around sg_table to get_pages/put_pages backend

2016-10-17 Thread Tvrtko Ursulin
On 17/10/2016 12:31, Chris Wilson wrote: On Mon, Oct 17, 2016 at 11:55:54AM +0100, Tvrtko Ursulin wrote: On 14/10/2016 13:18, Chris Wilson wrote: static void -i915_gem_object_put_pages_gtt(struct drm_i915_gem_object *obj) +i915_gem_object_put_pages_gtt(struct drm_i915_gem_object *obj, +

Re: [Intel-gfx] [PATCH 17/41] drm/i915: Pass around sg_table to get_pages/put_pages backend

2016-10-17 Thread Chris Wilson
On Mon, Oct 17, 2016 at 11:55:54AM +0100, Tvrtko Ursulin wrote: > On 14/10/2016 13:18, Chris Wilson wrote: > > static void > >-i915_gem_object_put_pages_gtt(struct drm_i915_gem_object *obj) > >+i915_gem_object_put_pages_gtt(struct drm_i915_gem_object *obj, > >+ struct

Re: [Intel-gfx] [PATCH 17/41] drm/i915: Pass around sg_table to get_pages/put_pages backend

2016-10-17 Thread Tvrtko Ursulin
On 14/10/2016 13:18, Chris Wilson wrote: The plan is to move obj->pages out from under the struct_mutex into its own per-object lock. We need to prune any assumption of the struct_mutex from the get_pages/put_pages backends, and to make it easier we pass around the sg_table to operate on rather

[Intel-gfx] [PATCH 17/41] drm/i915: Pass around sg_table to get_pages/put_pages backend

2016-10-14 Thread Chris Wilson
The plan is to move obj->pages out from under the struct_mutex into its own per-object lock. We need to prune any assumption of the struct_mutex from the get_pages/put_pages backends, and to make it easier we pass around the sg_table to operate on rather than indirectly via the obj.