Re: [Intel-gfx] [PATCH 2/2] drm/i915/cnl: Fix PLL initialization for HDMI.

2017-10-16 Thread Rodrigo Vivi
On Wed, Oct 04, 2017 at 07:34:27PM +, Ausmus, James wrote: > On Tue, Oct 3, 2017 at 3:08 PM, Rodrigo Vivi wrote: > > HDMI Mode selection on CNL is on CFGCR0 for that PLL, not > > on in a global CTRL1 as it was on SKL. > > > > The original patch addressed this

Re: [Intel-gfx] [PATCH 2/2] drm/i915/cnl: Fix PLL initialization for HDMI.

2017-10-04 Thread Manasi Navare
Good catch. Looks good to me as per the Bspec. Reviewed-by: Manasi Navare Manasi On Tue, Oct 03, 2017 at 03:08:59PM -0700, Rodrigo Vivi wrote: > HDMI Mode selection on CNL is on CFGCR0 for that PLL, not > on in a global CTRL1 as it was on SKL. > > The original patch

Re: [Intel-gfx] [PATCH 2/2] drm/i915/cnl: Fix PLL initialization for HDMI.

2017-10-04 Thread Ausmus, James
On Tue, Oct 3, 2017 at 3:08 PM, Rodrigo Vivi wrote: > HDMI Mode selection on CNL is on CFGCR0 for that PLL, not > on in a global CTRL1 as it was on SKL. > > The original patch addressed this difference, but leaving behind > this single entry here. So we were checking the

[Intel-gfx] [PATCH 2/2] drm/i915/cnl: Fix PLL initialization for HDMI.

2017-10-03 Thread Rodrigo Vivi
HDMI Mode selection on CNL is on CFGCR0 for that PLL, not on in a global CTRL1 as it was on SKL. The original patch addressed this difference, but leaving behind this single entry here. So we were checking the wrong bits during the PLL initialization and consequently avoiding the CFGCR1 setup