Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: check eDP display control capability registers

2013-11-19 Thread Thierry Reding
On Mon, Nov 18, 2013 at 05:38:18PM +0100, Daniel Vetter wrote: > On Mon, Nov 18, 2013 at 5:31 PM, Thierry Reding > wrote: > >> Note that there's already a bit of abstraction for i2c over dp aux, but > >> imo that's at the wrong level. At least reading through i915, gma500 and > >> radeon code ther

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: check eDP display control capability registers

2013-11-18 Thread Daniel Vetter
On Mon, Nov 18, 2013 at 5:31 PM, Thierry Reding wrote: >> Note that there's already a bit of abstraction for i2c over dp aux, but >> imo that's at the wrong level. At least reading through i915, gma500 and >> radeon code there's a lot more we could share with just a dp aux helper >> library (which

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: check eDP display control capability registers

2013-11-18 Thread Thierry Reding
On Mon, Nov 18, 2013 at 05:20:54PM +0100, Daniel Vetter wrote: > On Mon, Nov 18, 2013 at 04:26:17PM +0100, Thierry Reding wrote: > > On Mon, Nov 18, 2013 at 10:09:56AM -0500, Alex Deucher wrote: > > > On Mon, Nov 18, 2013 at 9:27 AM, Thierry Reding > > > wrote: > > > > On Fri, Nov 15, 2013 at 03:0

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: check eDP display control capability registers

2013-11-18 Thread Daniel Vetter
On Mon, Nov 18, 2013 at 04:26:17PM +0100, Thierry Reding wrote: > On Mon, Nov 18, 2013 at 10:09:56AM -0500, Alex Deucher wrote: > > On Mon, Nov 18, 2013 at 9:27 AM, Thierry Reding > > wrote: > > > On Fri, Nov 15, 2013 at 03:01:51PM +0200, Jani Nikula wrote: > > >> Debug print the capabilities, and

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: check eDP display control capability registers

2013-11-18 Thread Thierry Reding
On Mon, Nov 18, 2013 at 10:09:56AM -0500, Alex Deucher wrote: > On Mon, Nov 18, 2013 at 9:27 AM, Thierry Reding > wrote: > > On Fri, Nov 15, 2013 at 03:01:51PM +0200, Jani Nikula wrote: > >> Debug print the capabilities, and flag an error if the panel does not > >> support adjusting backlight thro

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: check eDP display control capability registers

2013-11-18 Thread Alex Deucher
On Mon, Nov 18, 2013 at 9:27 AM, Thierry Reding wrote: > On Fri, Nov 15, 2013 at 03:01:51PM +0200, Jani Nikula wrote: >> Debug print the capabilities, and flag an error if the panel does not >> support adjusting backlight through the BL_PWM_DIM pin, requiring >> backlight control through DPCD. >>

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: check eDP display control capability registers

2013-11-18 Thread Thierry Reding
On Fri, Nov 15, 2013 at 03:01:51PM +0200, Jani Nikula wrote: > Debug print the capabilities, and flag an error if the panel does not > support adjusting backlight through the BL_PWM_DIM pin, requiring > backlight control through DPCD. > > I haven't seen such panels yet, but it's a matter of time.

[Intel-gfx] [PATCH 2/2] drm/i915/dp: check eDP display control capability registers

2013-11-15 Thread Jani Nikula
Debug print the capabilities, and flag an error if the panel does not support adjusting backlight through the BL_PWM_DIM pin, requiring backlight control through DPCD. I haven't seen such panels yet, but it's a matter of time. Give ourselves a reminder when we need to fix this for real. Signed-of