Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Remove wait_for_idle() for PSR2

2018-08-20 Thread Rodrigo Vivi
On Wed, Aug 15, 2018 at 06:35:15PM -0700, Dhinakaran Pandiyan wrote: > On Mon, 2018-08-13 at 18:10 +, Pandiyan, Dhinakaran wrote: > > On Mon, 2018-08-13 at 09:57 -0700, Rodrigo Vivi wrote: > > > On Thu, Aug 09, 2018 at 05:41:35PM -0700, Dhinakaran Pandiyan > > > wrote: > > > > CI runs show

Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Remove wait_for_idle() for PSR2

2018-08-15 Thread Dhinakaran Pandiyan
On Mon, 2018-08-13 at 18:10 +, Pandiyan, Dhinakaran wrote: > On Mon, 2018-08-13 at 09:57 -0700, Rodrigo Vivi wrote: > > On Thu, Aug 09, 2018 at 05:41:35PM -0700, Dhinakaran Pandiyan > > wrote: > > > CI runs show PSR2 does not go to IDLE with selective update > > > enabled > > > on > > > all

Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Remove wait_for_idle() for PSR2

2018-08-13 Thread Pandiyan, Dhinakaran
On Mon, 2018-08-13 at 11:17 -0700, Tarun Vyas wrote: > On Mon, Aug 13, 2018 at 11:10:00AM -0700, Pandiyan, Dhinakaran wrote: > > On Mon, 2018-08-13 at 09:57 -0700, Rodrigo Vivi wrote: > > > On Thu, Aug 09, 2018 at 05:41:35PM -0700, Dhinakaran Pandiyan > > > wrote: > > > > CI runs show PSR2 does

Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Remove wait_for_idle() for PSR2

2018-08-13 Thread Tarun Vyas
On Mon, Aug 13, 2018 at 11:10:00AM -0700, Pandiyan, Dhinakaran wrote: > On Mon, 2018-08-13 at 09:57 -0700, Rodrigo Vivi wrote: > > On Thu, Aug 09, 2018 at 05:41:35PM -0700, Dhinakaran Pandiyan wrote: > > > CI runs show PSR2 does not go to IDLE with selective update enabled > > > on > > > all PSR

Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Remove wait_for_idle() for PSR2

2018-08-13 Thread Pandiyan, Dhinakaran
On Mon, 2018-08-13 at 09:57 -0700, Rodrigo Vivi wrote: > On Thu, Aug 09, 2018 at 05:41:35PM -0700, Dhinakaran Pandiyan wrote: > > CI runs show PSR2 does not go to IDLE with selective update enabled > > on > > all PSR exit triggers. Specifically, logs indicate the hardware > > enters > > "SLEEP

Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Remove wait_for_idle() for PSR2

2018-08-13 Thread Rodrigo Vivi
On Thu, Aug 09, 2018 at 05:41:35PM -0700, Dhinakaran Pandiyan wrote: > CI runs show PSR2 does not go to IDLE with selective update enabled on > all PSR exit triggers. Specifically, logs indicate the hardware enters > "SLEEP Selective Update" and not "IDLE Reset state' like the kernel > expects.

[Intel-gfx] [PATCH 2/2] drm/i915/psr: Remove wait_for_idle() for PSR2

2018-08-09 Thread Dhinakaran Pandiyan
CI runs show PSR2 does not go to IDLE with selective update enabled on all PSR exit triggers. Specifically, logs indicate the hardware enters "SLEEP Selective Update" and not "IDLE Reset state' like the kernel expects. This check was added for PSR1 but incorrectly extended to PSR2, remove this