Re: [Intel-gfx] [PATCH 2/2] drm/i915/vlv: use correct units for rc6 residency v2

2013-09-27 Thread Daniel Vetter
On Fri, Sep 27, 2013 at 09:15:58AM +0100, Chris Wilson wrote: > On Thu, Sep 26, 2013 at 05:55:58PM -0700, Jesse Barnes wrote: > > We need to use the clock control reg to figure out how many CZ clks are in > > 30ns and use that as the basis for our RC6 residency calculations. > > > > v2: use ULL ev

Re: [Intel-gfx] [PATCH 2/2] drm/i915/vlv: use correct units for rc6 residency v2

2013-09-27 Thread Chris Wilson
On Thu, Sep 26, 2013 at 05:55:58PM -0700, Jesse Barnes wrote: > We need to use the clock control reg to figure out how many CZ clks are in > 30ns and use that as the basis for our RC6 residency calculations. > > v2: use ULL everywhere for consistency (Chris) > factor out bias for clarity (Chri

[Intel-gfx] [PATCH 2/2] drm/i915/vlv: use correct units for rc6 residency v2

2013-09-26 Thread Jesse Barnes
We need to use the clock control reg to figure out how many CZ clks are in 30ns and use that as the basis for our RC6 residency calculations. v2: use ULL everywhere for consistency (Chris) factor out bias for clarity (Chris) References: https://bugs.freedesktop.org/show_bug.cgi?id=69692 Signe

Re: [Intel-gfx] [PATCH 2/2] drm/i915/vlv: use correct units for rc6 residency

2013-09-26 Thread Jesse Barnes
On Fri, 27 Sep 2013 01:49:37 +0100 Chris Wilson wrote: > On Thu, Sep 26, 2013 at 03:34:33PM -0700, Jesse Barnes wrote: > > On Thu, 26 Sep 2013 23:25:46 +0100 > > Chris Wilson wrote: > > > > > > > > > > > if (!intel_enable_rc6(dev)) > > > > return 0; > > > > > > > > -

Re: [Intel-gfx] [PATCH 2/2] drm/i915/vlv: use correct units for rc6 residency

2013-09-26 Thread Chris Wilson
On Thu, Sep 26, 2013 at 03:34:33PM -0700, Jesse Barnes wrote: > On Thu, 26 Sep 2013 23:25:46 +0100 > Chris Wilson wrote: > > > > > > > > if (!intel_enable_rc6(dev)) > > > return 0; > > > > > > - raw_time = I915_READ(reg) * 128ULL; > > > - return DIV_ROUND_UP_ULL(raw_time, 10);

Re: [Intel-gfx] [PATCH 2/2] drm/i915/vlv: use correct units for rc6 residency

2013-09-26 Thread Jesse Barnes
On Thu, 26 Sep 2013 23:25:46 +0100 Chris Wilson wrote: > On Thu, Sep 26, 2013 at 12:33:21PM -0700, Jesse Barnes wrote: > > We need to use the clock control reg to figure out how many CZ clks are in > > 30ns and use that as the basis for our RC6 residency calculations. > > Hmm, that was confusing

Re: [Intel-gfx] [PATCH 2/2] drm/i915/vlv: use correct units for rc6 residency

2013-09-26 Thread Chris Wilson
On Thu, Sep 26, 2013 at 12:33:21PM -0700, Jesse Barnes wrote: > We need to use the clock control reg to figure out how many CZ clks are in > 30ns and use that as the basis for our RC6 residency calculations. Hmm, that was confusing. Took a couple of reads to be sure that the specs said that the un

[Intel-gfx] [PATCH 2/2] drm/i915/vlv: use correct units for rc6 residency

2013-09-26 Thread Jesse Barnes
We need to use the clock control reg to figure out how many CZ clks are in 30ns and use that as the basis for our RC6 residency calculations. References: https://bugs.freedesktop.org/show_bug.cgi?id=69692 Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm