Re: [Intel-gfx] [PATCH 2/2] drm/i915: Compare user's 64b GTT offset even on 32b

2018-11-14 Thread Lionel Landwerlin
Reminds me that we should probably update the uAPI... struct drm_i915_gem_exec_object2 has a u64 flags and all the EXEC_OBJECT_* flags are (1< - Lionel On 25/10/2018 10:18, Chris Wilson wrote: Beware mixing unsigned long constants and 64b values, as on 32b the constant will be zero extended

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Compare user's 64b GTT offset even on 32b

2018-10-25 Thread Matthew Auld
On Thu, 25 Oct 2018 at 10:18, Chris Wilson wrote: > > Beware mixing unsigned long constants and 64b values, as on 32b the > constant will be zero extended and discard the high 32b when used as > a mask! > > Reported-by: Sergii Romantsov > Bugzilla:

[Intel-gfx] [PATCH 2/2] drm/i915: Compare user's 64b GTT offset even on 32b

2018-10-25 Thread Chris Wilson
Beware mixing unsigned long constants and 64b values, as on 32b the constant will be zero extended and discard the high 32b when used as a mask! Reported-by: Sergii Romantsov Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108282 Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: