Re: [Intel-gfx] [PATCH 2/2] drm/i915: Don't BUG_ON in i915_gem_obj_offset

2014-06-24 Thread Ben Widawsky
On Wed, Jun 25, 2014 at 12:00:35PM +1000, Dave Airlie wrote: On 25 June 2014 11:30, Ben Widawsky b...@bwidawsk.net wrote: On Wed, Jun 18, 2014 at 12:04:46AM +0200, Daniel Vetter wrote: On Tue, Jun 17, 2014 at 10:34:38PM +0200, Daniel Vetter wrote: A WARN_ON is perfectly fine. The BUG

[Intel-gfx] [PATCH 2/2] drm/i915: Don't BUG_ON in i915_gem_obj_offset

2014-06-17 Thread Daniel Vetter
A WARN_ON is perfectly fine. The BUG in here seems to be the cause behind hard-hangs when I cat the i915_gem_pageflip debugfs file (which calls this from an irq spinlock). But only while running a full igt run after a while. I still need to root cause the underlying issue. I'll also start reject

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Don't BUG_ON in i915_gem_obj_offset

2014-06-17 Thread Daniel Vetter
On Tue, Jun 17, 2014 at 10:34:38PM +0200, Daniel Vetter wrote: A WARN_ON is perfectly fine. The BUG in here seems to be the cause behind hard-hangs when I cat the i915_gem_pageflip debugfs file (which calls this from an irq spinlock). But only while running a full igt run after a while. I