Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix the return value of pipe crc read function.

2016-08-05 Thread Pandiyan, Dhinakaran
On Wed, 2016-08-03 at 14:44 +, Vivi, Rodrigo wrote: > On Wed, 2016-08-03 at 10:31 +0300, Ville Syrjälä wrote: > > On Tue, Aug 02, 2016 at 09:42:07PM -0700, Rodrigo Vivi wrote: > > > > > > A read(fd, buf, len) function should return the number > > > of bytes read. In our case we need to return

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix the return value of pipe crc read function.

2016-08-03 Thread Vivi, Rodrigo
On Wed, 2016-08-03 at 10:31 +0300, Ville Syrjälä wrote: > On Tue, Aug 02, 2016 at 09:42:07PM -0700, Rodrigo Vivi wrote: > > > > A read(fd, buf, len) function should return the number > > of bytes read. In our case we need to return the > > number of bytes we copy to user, instead of returning > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix the return value of pipe crc read function.

2016-08-03 Thread Daniel Vetter
On Tue, Aug 02, 2016 at 09:42:07PM -0700, Rodrigo Vivi wrote: > A read(fd, buf, len) function should return the number > of bytes read. In our case we need to return the > number of bytes we copy to user, instead of returning > the number of bytes we read internally. > > It was really strange when

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix the return value of pipe crc read function.

2016-08-03 Thread Ville Syrjälä
On Tue, Aug 02, 2016 at 09:42:07PM -0700, Rodrigo Vivi wrote: > A read(fd, buf, len) function should return the number > of bytes read. In our case we need to return the > number of bytes we copy to user, instead of returning > the number of bytes we read internally. > > It was really strange when

[Intel-gfx] [PATCH 2/2] drm/i915: Fix the return value of pipe crc read function.

2016-08-02 Thread Rodrigo Vivi
A read(fd, buf, len) function should return the number of bytes read. In our case we need to return the number of bytes we copy to user, instead of returning the number of bytes we read internally. It was really strange when I saw i-g-t test case using len '54' but getting '56' as return. First th