Re: [Intel-gfx] [PATCH 2/2] drm/i915: cleanup TLB invalidation code

2022-12-09 Thread Tvrtko Ursulin
On 09/12/2022 12:04, Tvrtko Ursulin wrote: On 09/12/2022 11:33, Andrzej Hajda wrote: On 09.12.2022 11:16, Tvrtko Ursulin wrote: On 07/12/2022 17:36, Andrzej Hajda wrote: Whole register/bit selection logic has been moved to separate helper. Why is missing. ...to clean up

Re: [Intel-gfx] [PATCH 2/2] drm/i915: cleanup TLB invalidation code

2022-12-09 Thread Tvrtko Ursulin
On 09/12/2022 11:33, Andrzej Hajda wrote: On 09.12.2022 11:16, Tvrtko Ursulin wrote: On 07/12/2022 17:36, Andrzej Hajda wrote: Whole register/bit selection logic has been moved to separate helper. Why is missing. ...to clean up mmio_invalidate_full function. Will add.

Re: [Intel-gfx] [PATCH 2/2] drm/i915: cleanup TLB invalidation code

2022-12-09 Thread Andrzej Hajda
On 09.12.2022 11:16, Tvrtko Ursulin wrote: On 07/12/2022 17:36, Andrzej Hajda wrote: Whole register/bit selection logic has been moved to separate helper. Why is missing. ...to clean up mmio_invalidate_full function. Will add. Signed-off-by: Andrzej Hajda ---  

Re: [Intel-gfx] [PATCH 2/2] drm/i915: cleanup TLB invalidation code

2022-12-09 Thread Tvrtko Ursulin
On 07/12/2022 17:36, Andrzej Hajda wrote: Whole register/bit selection logic has been moved to separate helper. Why is missing. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_gt.c | 136 +++-- 1 file changed, 51 insertions(+), 85 deletions(-)

[Intel-gfx] [PATCH 2/2] drm/i915: cleanup TLB invalidation code

2022-12-07 Thread Andrzej Hajda
Whole register/bit selection logic has been moved to separate helper. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_gt.c | 136 +++-- 1 file changed, 51 insertions(+), 85 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c