Re: [Intel-gfx] [PATCH 2/2] drm/i915: reword documentation of possible pci_device_id struct

2018-09-04 Thread Jani Nikula
On Tue, 28 Aug 2018, Lucas De Marchi wrote: > On Tue, Aug 28, 2018 at 07:05:46PM +0100, Chris Wilson wrote: >> Quoting Lucas De Marchi (2018-08-28 18:41:46) >> > Document it like a real struct for ease of copy and paste, remove >> > comment of C99 compatibility and document that in some cases the

Re: [Intel-gfx] [PATCH 2/2] drm/i915: reword documentation of possible pci_device_id struct

2018-08-28 Thread Lucas De Marchi
On Tue, Aug 28, 2018 at 09:06:15PM +0300, Ville Syrjälä wrote: > On Tue, Aug 28, 2018 at 10:41:46AM -0700, Lucas De Marchi wrote: > > Document it like a real struct for ease of copy and paste, remove > > comment of C99 compatibility and document that in some cases the first 2 > > fields can be u16.

Re: [Intel-gfx] [PATCH 2/2] drm/i915: reword documentation of possible pci_device_id struct

2018-08-28 Thread Lucas De Marchi
On Tue, Aug 28, 2018 at 07:05:46PM +0100, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-08-28 18:41:46) > > Document it like a real struct for ease of copy and paste, remove > > comment of C99 compatibility and document that in some cases the first 2 > > I do recall that we couldn't use eith

Re: [Intel-gfx] [PATCH 2/2] drm/i915: reword documentation of possible pci_device_id struct

2018-08-28 Thread Ville Syrjälä
On Tue, Aug 28, 2018 at 10:41:46AM -0700, Lucas De Marchi wrote: > Document it like a real struct for ease of copy and paste, remove > comment of C99 compatibility and document that in some cases the first 2 > fields can be u16. > > Cc: Chris Wilson > Signed-off-by: Lucas De Marchi > --- > incl

Re: [Intel-gfx] [PATCH 2/2] drm/i915: reword documentation of possible pci_device_id struct

2018-08-28 Thread Chris Wilson
Quoting Lucas De Marchi (2018-08-28 18:41:46) > Document it like a real struct for ease of copy and paste, remove > comment of C99 compatibility and document that in some cases the first 2 I do recall that we couldn't use either C99 or class due to userspace compatibility... The essence is that we

[Intel-gfx] [PATCH 2/2] drm/i915: reword documentation of possible pci_device_id struct

2018-08-28 Thread Lucas De Marchi
Document it like a real struct for ease of copy and paste, remove comment of C99 compatibility and document that in some cases the first 2 fields can be u16. Cc: Chris Wilson Signed-off-by: Lucas De Marchi --- include/drm/i915_pciids.h | 16 +--- 1 file changed, 9 insertions(+), 7 d