Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-17 Thread Matt Roper
On Thu, Nov 17, 2022 at 03:00:01PM -0800, Anusha Srivatsa wrote: > From: Ville Syrjälä > > For MTL, changing cdclk from between certain frequencies has > both squash and crawl. Use the current cdclk config and > the new(desired) cdclk config to construtc a mid cdclk config.

[Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-17 Thread Anusha Srivatsa
From: Ville Syrjälä For MTL, changing cdclk from between certain frequencies has both squash and crawl. Use the current cdclk config and the new(desired) cdclk config to construtc a mid cdclk config. Set the cdclk twice: - Current cdclk -> mid cdclk - mid cdclk -> desired cdclk Driver should

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-16 Thread Matt Roper
On Wed, Nov 16, 2022 at 01:50:39PM -0800, Anusha Srivatsa wrote: > From: Ville Syrjälä > > For MTL, changing cdclk from between certain frequencies has > both squash and crawl. Use the current cdclk config and > the new(desired) cdclk config to construct a mid cdclk config. > Set the cdclk

[Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-16 Thread Anusha Srivatsa
From: Ville Syrjälä For MTL, changing cdclk from between certain frequencies has both squash and crawl. Use the current cdclk config and the new(desired) cdclk config to construct a mid cdclk config. Set the cdclk twice: - Current cdclk -> mid cdclk - mid cdclk -> desired cdclk Driver should

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-16 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Wednesday, November 16, 2022 10:44 AM > To: Srivatsa, Anusha > Cc: intel-gfx@lists.freedesktop.org; Vivekanandan, Balasubramani > > Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and &

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-16 Thread Matt Roper
On Wed, Nov 16, 2022 at 06:50:07AM -0800, Anusha Srivatsa wrote: > From: Ville Syrjälä > > For MTL, changing cdclk from between certain frequencies has > both squash and crawl. Use the current cdclk config and > the new(desired) cdclk config to construtc a mid cdclk config. > Set the cdclk

[Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-16 Thread Anusha Srivatsa
From: Ville Syrjälä For MTL, changing cdclk from between certain frequencies has both squash and crawl. Use the current cdclk config and the new(desired) cdclk config to construtc a mid cdclk config. Set the cdclk twice: - Current cdclk -> mid cdclk - mid cdclk -> desired cdclk Driver should

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-15 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Monday, November 14, 2022 4:43 PM > To: Srivatsa, Anusha > Cc: intel-gfx@lists.freedesktop.org; Ville Syrjälä > > Subject: Re: [PATCH 2/3] drm/i915/display: Do both crawl and squash when > changing cdclk > > On Mon, Nov 14, 2022

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-14 Thread Matt Roper
On Mon, Nov 14, 2022 at 04:07:13PM -0800, Srivatsa, Anusha wrote: > > > > -Original Message- > > From: Roper, Matthew D > > Sent: Monday, November 14, 2022 4:01 PM > > To: Srivatsa, Anusha > > Cc: intel-gfx@lists.freedesktop.org; Ville Syrjälä > > > > Subject: Re: [PATCH 2/3]

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-14 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Monday, November 14, 2022 4:01 PM > To: Srivatsa, Anusha > Cc: intel-gfx@lists.freedesktop.org; Ville Syrjälä > > Subject: Re: [PATCH 2/3] drm/i915/display: Do both crawl and squash when > changing cdclk > > On Mon, Nov 14, 2022

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-14 Thread Matt Roper
On Mon, Nov 14, 2022 at 03:14:33PM -0800, Srivatsa, Anusha wrote: ... > > > +static void bxt_set_cdclk(struct drm_i915_private *dev_priv, > > > + const struct intel_cdclk_config *cdclk_config, > > > + enum pipe pipe) > > > +{ > > > + struct intel_cdclk_config

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-14 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Monday, November 14, 2022 2:16 PM > To: Srivatsa, Anusha > Cc: intel-gfx@lists.freedesktop.org; Ville Syrjälä > > Subject: Re: [PATCH 2/3] drm/i915/display: Do both crawl and squash when > changing cdclk > > On Mon, Nov 14, 2022

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-14 Thread Matt Roper
On Mon, Nov 14, 2022 at 12:57:16PM -0800, Anusha Srivatsa wrote: > From: Ville Syrjälä > > For MTL, changing cdclk from between certain frequencies has > both squash and crawl. Use the current cdclk config and > the new(desired) cdclk config to construtc a mid cdclk config. > Set the cdclk

[Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-14 Thread Anusha Srivatsa
From: Ville Syrjälä For MTL, changing cdclk from between certain frequencies has both squash and crawl. Use the current cdclk config and the new(desired) cdclk config to construtc a mid cdclk config. Set the cdclk twice: - Current cdclk -> mid cdclk - mid cdclk -> desired cdclk v2: Add check in