Re: [Intel-gfx] [PATCH 2/3] drm/i915: Convert DIP port switch cases to a simple macro

2014-02-13 Thread Daniel Vetter
On Mon, Feb 10, 2014 at 12:11:33PM +, Damien Lespiau wrote: > On Thu, Jan 23, 2014 at 11:15:34PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > We have a couple of switch cases to compute the port value for the > > VIDEO_DIP_CTL register. Replace them with a simpl

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Convert DIP port switch cases to a simple macro

2014-02-10 Thread Damien Lespiau
On Thu, Jan 23, 2014 at 11:15:34PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We have a couple of switch cases to compute the port value for the > VIDEO_DIP_CTL register. Replace them with a simple macro. > > We do lose a few BUG() calls, but many people may consider t

[Intel-gfx] [PATCH 2/3] drm/i915: Convert DIP port switch cases to a simple macro

2014-01-23 Thread ville . syrjala
From: Ville Syrjälä We have a couple of switch cases to compute the port value for the VIDEO_DIP_CTL register. Replace them with a simple macro. We do lose a few BUG() calls, but many people may consider that an improvement. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h |