Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix obj->map_and_fenceable for ppgtt

2014-08-10 Thread Chris Wilson
On Sun, Aug 10, 2014 at 07:55:46AM +0100, Chris Wilson wrote: > On Sat, Aug 09, 2014 at 12:29:17PM -0700, Ben Widawsky wrote: > > I didn't read the patch closely, but the problem is clear. It seems like > > the one hunk: > > > - if (use_cpu_reloc(obj)) > > > + if (use_cpu_reloc(obj) || !i91

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix obj->map_and_fenceable for ppgtt

2014-08-09 Thread Chris Wilson
On Sat, Aug 09, 2014 at 12:29:17PM -0700, Ben Widawsky wrote: > On Sat, Aug 09, 2014 at 05:37:23PM +0100, Chris Wilson wrote: > > With ppgtt, it is no longer correct to mark an object as > > map_and_fenceable if we simply unbind it from the global gtt. This has > > consequences during execbuffer wh

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix obj->map_and_fenceable for ppgtt

2014-08-09 Thread Ben Widawsky
On Sat, Aug 09, 2014 at 05:37:23PM +0100, Chris Wilson wrote: > With ppgtt, it is no longer correct to mark an object as > map_and_fenceable if we simply unbind it from the global gtt. This has > consequences during execbuffer where we simply use > obj->map_and_fenceable in use_cpu_reloc() to decid

[Intel-gfx] [PATCH 2/3] drm/i915: Fix obj->map_and_fenceable for ppgtt

2014-08-09 Thread Chris Wilson
With ppgtt, it is no longer correct to mark an object as map_and_fenceable if we simply unbind it from the global gtt. This has consequences during execbuffer where we simply use obj->map_and_fenceable in use_cpu_reloc() to decide which access method to use for writing into the object. Now for a pp

[Intel-gfx] [PATCH 2/3] drm/i915: Fix obj->map_and_fenceable for ppgtt

2014-01-01 Thread Chris Wilson
With ppgtt, it is no longer correct to mark an object as map_and_fenceable if we simply unbind it from the global gtt. This has consequences during execbuffer where we simply use obj->map_and_fenceable in use_cpu_reloc() to decide which access method to use for writing into the object. Now for a pp