Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

On Wed, May 17, 2017 at 8:38 PM, Rob Clark wrote: > On Wed, May 17, 2017 at 8:00 PM, Ben Widawsky wrote: >> On 17-05-17 13:31:44, Daniel Vetter wrote: >>> >>> On Tue, May 16, 2017 at 02:19:12PM -0700, Ben Widawsky wrote: On 17-05-03 17:08:27,

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

On Wed, May 17, 2017 at 8:00 PM, Ben Widawsky wrote: > On 17-05-17 13:31:44, Daniel Vetter wrote: >> >> On Tue, May 16, 2017 at 02:19:12PM -0700, Ben Widawsky wrote: >>> >>> On 17-05-03 17:08:27, Daniel Vetter wrote: >>> > On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

On 17-05-17 13:31:44, Daniel Vetter wrote: On Tue, May 16, 2017 at 02:19:12PM -0700, Ben Widawsky wrote: On 17-05-03 17:08:27, Daniel Vetter wrote: > On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: > > +struct drm_format_modifier_blob { > > +#define FORMAT_BLOB_CURRENT 1 > > +

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

On Wed, May 17, 2017 at 1:31 PM, Daniel Vetter wrote: > On Tue, May 16, 2017 at 02:19:12PM -0700, Ben Widawsky wrote: >> On 17-05-03 17:08:27, Daniel Vetter wrote: >> > On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: >> > > +struct drm_format_modifier_blob { >> > >

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

On Tue, May 16, 2017 at 02:19:12PM -0700, Ben Widawsky wrote: > On 17-05-03 17:08:27, Daniel Vetter wrote: > > On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: > > > +struct drm_format_modifier_blob { > > > +#define FORMAT_BLOB_CURRENT 1 > > > + /* Version of this blob format */ > > >

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

On 17-05-03 17:08:27, Daniel Vetter wrote: On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: Updated blob layout (Rob, Daniel, Kristian, xerpi) Cc: Rob Clark Cc: Daniel Stone Cc: Kristian H. Kristensen

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

On 17-05-03 14:15:15, Liviu Dudau wrote: On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: Updated blob layout (Rob, Daniel, Kristian, xerpi) Cc: Rob Clark Cc: Daniel Stone Cc: Kristian H. Kristensen Signed-off-by:

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

Hi, On 3 May 2017 at 06:14, Ben Widawsky wrote: > Updated blob layout (Rob, Daniel, Kristian, xerpi) In terms of the blob as uABI, we've got an implementation inside Weston which works:

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: > Updated blob layout (Rob, Daniel, Kristian, xerpi) > > Cc: Rob Clark > Cc: Daniel Stone > Cc: Kristian H. Kristensen > Signed-off-by: Ben Widawsky

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

Hi Daniel, On Wed, May 03, 2017 at 03:07:40PM +0100, Daniel Stone wrote: Hi Brian, On 3 May 2017 at 15:03, Brian Starkey wrote: On Wed, May 03, 2017 at 02:51:18PM +0100, Daniel Stone wrote: formats_offset is the end of the fixed-size element, which is currently

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

Hi Brian, On 3 May 2017 at 15:03, Brian Starkey wrote: > On Wed, May 03, 2017 at 02:51:18PM +0100, Daniel Stone wrote: >> formats_offset is the end of the fixed-size element, which is >> currently aligned to 32 bytes, and practically speaking would always >> have to be

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

On Wed, May 03, 2017 at 02:51:18PM +0100, Daniel Stone wrote: Hi Brian, On 3 May 2017 at 13:51, Brian Starkey wrote: On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: + modifiers_size = + sizeof(struct drm_format_modifier) *

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

Hi Brian, On 3 May 2017 at 13:51, Brian Starkey wrote: > On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: >> + modifiers_size = >> + sizeof(struct drm_format_modifier) * >> format_modifier_count; >> + >> + blob_size =

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

Hi Ben, On 3 May 2017 at 06:14, Ben Widawsky wrote: > +struct drm_format_modifier_blob { > +#define FORMAT_BLOB_CURRENT 1 > + /* Version of this blob format */ > + u32 version; > + > + /* Flags */ > + u32 flags; > + > + /* Number of fourcc

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: > Updated blob layout (Rob, Daniel, Kristian, xerpi) > > Cc: Rob Clark > Cc: Daniel Stone > Cc: Kristian H. Kristensen > Signed-off-by: Ben Widawsky

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

Hi, On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: Updated blob layout (Rob, Daniel, Kristian, xerpi) Cc: Rob Clark Cc: Daniel Stone Cc: Kristian H. Kristensen Signed-off-by: Ben Widawsky ---

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

Hi Daniel, On Wed, May 03, 2017 at 12:47:18PM +0100, Daniel Stone wrote: Hi Brian, On 3 May 2017 at 12:00, Brian Starkey wrote: Having just caught up on IRC I'm sure I'm far too late for this party, but... Wouldn't this whole thing be a whole lot simpler if

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

Hi Brian, On 3 May 2017 at 12:00, Brian Starkey wrote: > Having just caught up on IRC I'm sure I'm far too late for this party, > but... > > Wouldn't this whole thing be a whole lot simpler if "IN_FORMATS" > stored "pointers" to separate blobs for the format and modifier

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

Hi, Having just caught up on IRC I'm sure I'm far too late for this party, but... Wouldn't this whole thing be a whole lot simpler if "IN_FORMATS" stored "pointers" to separate blobs for the format and modifier lists? struct drm_format_modifier_blob { #define FORMAT_BLOB_CURRENT 1 /*

[Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

Updated blob layout (Rob, Daniel, Kristian, xerpi) Cc: Rob Clark Cc: Daniel Stone Cc: Kristian H. Kristensen Signed-off-by: Ben Widawsky --- drivers/gpu/drm/drm_mode_config.c | 7 +++