Re: [Intel-gfx] [PATCH 2/4] drm/i915/vrr: Fix guardband/vblank exit length calculation for adl+

2022-12-08 Thread Navare, Manasi
On Wed, Dec 07, 2022 at 11:35:24PM +0200, Ville Syrjälä wrote: > On Wed, Dec 07, 2022 at 01:05:15PM -0800, Navare, Manasi wrote: > > On Wed, Dec 07, 2022 at 05:10:54PM +0200, Ville Syrjälä wrote: > > > On Mon, Dec 05, 2022 at 12:34:25PM -0800, Navare, Manasi wrote: > > > > On Fri, Dec 02, 2022 at 0

Re: [Intel-gfx] [PATCH 2/4] drm/i915/vrr: Fix guardband/vblank exit length calculation for adl+

2022-12-07 Thread Ville Syrjälä
On Wed, Dec 07, 2022 at 01:05:15PM -0800, Navare, Manasi wrote: > On Wed, Dec 07, 2022 at 05:10:54PM +0200, Ville Syrjälä wrote: > > On Mon, Dec 05, 2022 at 12:34:25PM -0800, Navare, Manasi wrote: > > > On Fri, Dec 02, 2022 at 03:44:10PM +0200, Ville Syrjala wrote: > > > > From: Ville Syrjälä > >

Re: [Intel-gfx] [PATCH 2/4] drm/i915/vrr: Fix guardband/vblank exit length calculation for adl+

2022-12-07 Thread Navare, Manasi
On Wed, Dec 07, 2022 at 05:10:54PM +0200, Ville Syrjälä wrote: > On Mon, Dec 05, 2022 at 12:34:25PM -0800, Navare, Manasi wrote: > > On Fri, Dec 02, 2022 at 03:44:10PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > We are miscalculating both the guardband value, and the resulti

Re: [Intel-gfx] [PATCH 2/4] drm/i915/vrr: Fix guardband/vblank exit length calculation for adl+

2022-12-07 Thread Ville Syrjälä
On Mon, Dec 05, 2022 at 12:34:25PM -0800, Navare, Manasi wrote: > On Fri, Dec 02, 2022 at 03:44:10PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We are miscalculating both the guardband value, and the resulting > > vblank exit length on adl+. This means that our start of vblank >

Re: [Intel-gfx] [PATCH 2/4] drm/i915/vrr: Fix guardband/vblank exit length calculation for adl+

2022-12-05 Thread Navare, Manasi
On Fri, Dec 02, 2022 at 03:44:10PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > We are miscalculating both the guardband value, and the resulting > vblank exit length on adl+. This means that our start of vblank > (double buffered register latch point) is incorrect, and we also > think t

[Intel-gfx] [PATCH 2/4] drm/i915/vrr: Fix guardband/vblank exit length calculation for adl+

2022-12-02 Thread Ville Syrjala
From: Ville Syrjälä We are miscalculating both the guardband value, and the resulting vblank exit length on adl+. This means that our start of vblank (double buffered register latch point) is incorrect, and we also think that it's not where it actually is (hence vblank evasion/etc. may not work p