Re: [Intel-gfx] [PATCH 2/4] drm/i915: Don't check for wm changes until we've compute the wms fully

On Wed, Mar 04, 2020 at 11:25:42PM +, Souza, Jose wrote: > On Wed, 2020-03-04 at 13:46 +0200, Ville Syrjälä wrote: > > On Wed, Mar 04, 2020 at 12:21:01AM +, Souza, Jose wrote: > > > On Fri, 2020-02-28 at 22:35 +0200, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > > > > > > >

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Don't check for wm changes until we've compute the wms fully

On Wed, 2020-03-04 at 13:46 +0200, Ville Syrjälä wrote: > On Wed, Mar 04, 2020 at 12:21:01AM +, Souza, Jose wrote: > > On Fri, 2020-02-28 at 22:35 +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Currently we're comparing the watermarks between the old and new > > > states >

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Don't check for wm changes until we've compute the wms fully

On Wed, Mar 04, 2020 at 12:21:01AM +, Souza, Jose wrote: > On Fri, 2020-02-28 at 22:35 +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Currently we're comparing the watermarks between the old and new > > states > > before we've fully computed the new watermarks. In particular > >

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Don't check for wm changes until we've compute the wms fully

On Fri, 2020-02-28 at 22:35 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we're comparing the watermarks between the old and new > states > before we've fully computed the new watermarks. In particular > skl_build_pipe_wm() will not account for the amount of ddb space > we'll >

[Intel-gfx] [PATCH 2/4] drm/i915: Don't check for wm changes until we've compute the wms fully

From: Ville Syrjälä Currently we're comparing the watermarks between the old and new states before we've fully computed the new watermarks. In particular skl_build_pipe_wm() will not account for the amount of ddb space we'll have. That information is only available during skl_compute_ddb() which