Re: [Intel-gfx] [PATCH 2/5] drm/i915/bdw: Implement a basic PM interrupt handler

2014-05-16 Thread Daniel Vetter
On Fri, May 16, 2014 at 12:46:00PM +0300, Ville Syrjälä wrote: > On Fri, May 16, 2014 at 11:09:35AM +0200, Daniel Vetter wrote: > > On Fri, May 16, 2014 at 01:38:18AM +, O'Rourke, Tom wrote: > > > >+static void gen8_disable_rps_interrupts(struct drm_device *dev) { > > > >+struct drm_i91

Re: [Intel-gfx] [PATCH 2/5] drm/i915/bdw: Implement a basic PM interrupt handler

2014-05-16 Thread Ville Syrjälä
On Fri, May 16, 2014 at 11:09:35AM +0200, Daniel Vetter wrote: > On Fri, May 16, 2014 at 01:38:18AM +, O'Rourke, Tom wrote: > > >+static void gen8_disable_rps_interrupts(struct drm_device *dev) { > > >+ struct drm_i915_private *dev_priv = dev->dev_private; > > >+ > > >+ I915_WRITE(GEN6_PMINTR

Re: [Intel-gfx] [PATCH 2/5] drm/i915/bdw: Implement a basic PM interrupt handler

2014-05-16 Thread Daniel Vetter
On Fri, May 16, 2014 at 01:38:18AM +, O'Rourke, Tom wrote: > >+static void gen8_disable_rps_interrupts(struct drm_device *dev) { > >+struct drm_i915_private *dev_priv = dev->dev_private; > >+ > >+I915_WRITE(GEN6_PMINTRMSK, 0x); > > [TOR:] Please note that for Broadwell, bit 31

Re: [Intel-gfx] [PATCH 2/5] drm/i915/bdw: Implement a basic PM interrupt handler

2014-05-15 Thread O'Rourke, Tom
>+static void gen8_disable_rps_interrupts(struct drm_device *dev) { >+ struct drm_i915_private *dev_priv = dev->dev_private; >+ >+ I915_WRITE(GEN6_PMINTRMSK, 0x); [TOR:] Please note that for Broadwell, bit 31 in GEN6_PMINTRMSK is not an interrupt disable bit. In "drm/i915: Enabl

[Intel-gfx] [PATCH 2/5] drm/i915/bdw: Implement a basic PM interrupt handler

2014-05-15 Thread Mika Kuoppala
From: Ben Widawsky Almost all of it is reusable from the existing code. The primary difference is we need to do even less in the interrupt handler, since interrupts are not shared in the same way. The patch is mostly a copy-paste of the existing snb+ code, with updates to the relevant parts requ