[Intel-gfx] [PATCH 2/5] drm/i915: add cpu_map to i915 object

2012-07-12 Thread Ben Widawsky
mostly for convenience, this will help us clear up a bit of the code in intel_ringbuffer.c Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gem.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/

Re: [Intel-gfx] [PATCH 2/5] drm/i915: add cpu_map to i915 object

2012-07-13 Thread Chris Wilson
On Thu, 12 Jul 2012 23:16:13 -0700, Ben Widawsky wrote: > mostly for convenience, this will help us clear up a bit of the code in > intel_ringbuffer.c I don't think your couple of use-cases is a strong enough argument to justify an extra pointer on thousands of objects. If you wanted, you could

Re: [Intel-gfx] [PATCH 2/5] drm/i915: add cpu_map to i915 object

2012-07-13 Thread Ben Widawsky
On Fri, 13 Jul 2012 08:47:15 +0100 Chris Wilson wrote: > On Thu, 12 Jul 2012 23:16:13 -0700, Ben Widawsky wrote: > > mostly for convenience, this will help us clear up a bit of the code in > > intel_ringbuffer.c > > I don't think your couple of use-cases is a strong enough argument to > justify

Re: [Intel-gfx] [PATCH 2/5] drm/i915: add cpu_map to i915 object

2012-07-13 Thread Chris Wilson
On Fri, 13 Jul 2012 06:56:44 -0700, Ben Widawsky wrote: > On Fri, 13 Jul 2012 08:47:15 +0100 > Chris Wilson wrote: > > > On Thu, 12 Jul 2012 23:16:13 -0700, Ben Widawsky wrote: > > > mostly for convenience, this will help us clear up a bit of the code in > > > intel_ringbuffer.c > > > > I don'