[Intel-gfx] [PATCH 2/7] dma-buf: Rename dma_resv helpers from _rcu to _unlocked (v2)

None of these helpers actually leak any RCU details to the caller. They all assume you have a genuine reference, take the RCU read lock, and retry if needed. Naming them with an _rcu is likely to cause callers more panic than needed. v2 (Jason Ekstrand): - Fix function argument indentation Sig

Re: [Intel-gfx] [PATCH 2/7] dma-buf: Rename dma_resv helpers from _rcu to _unlocked (v2)

Am 25.05.21 um 23:17 schrieb Jason Ekstrand: None of these helpers actually leak any RCU details to the caller. They all assume you have a genuine reference, take the RCU read lock, and retry if needed. Naming them with an _rcu is likely to cause callers more panic than needed. I'm really won

Re: [Intel-gfx] [PATCH 2/7] dma-buf: Rename dma_resv helpers from _rcu to _unlocked (v2)

On Wed, May 26, 2021 at 12:57:40PM +0200, Christian König wrote: > Am 25.05.21 um 23:17 schrieb Jason Ekstrand: > > None of these helpers actually leak any RCU details to the caller. They > > all assume you have a genuine reference, take the RCU read lock, and > > retry if needed. Naming them wit

Re: [Intel-gfx] [PATCH 2/7] dma-buf: Rename dma_resv helpers from _rcu to _unlocked (v2)

Am 27.05.21 um 12:39 schrieb Daniel Vetter: On Wed, May 26, 2021 at 12:57:40PM +0200, Christian König wrote: Am 25.05.21 um 23:17 schrieb Jason Ekstrand: None of these helpers actually leak any RCU details to the caller. They all assume you have a genuine reference, take the RCU read lock, and

Re: [Intel-gfx] [PATCH 2/7] dma-buf: Rename dma_resv helpers from _rcu to _unlocked (v2)

On Thu, May 27, 2021 at 1:59 PM Christian König wrote: > Am 27.05.21 um 12:39 schrieb Daniel Vetter: > > On Wed, May 26, 2021 at 12:57:40PM +0200, Christian König wrote: > >> Am 25.05.21 um 23:17 schrieb Jason Ekstrand: > >>> None of these helpers actually leak any RCU details to the caller. They

Re: [Intel-gfx] [PATCH 2/7] dma-buf: Rename dma_resv helpers from _rcu to _unlocked (v2)

On Thu, May 27, 2021 at 1:59 PM Christian König wrote: > > Am 27.05.21 um 12:39 schrieb Daniel Vetter: > > On Wed, May 26, 2021 at 12:57:40PM +0200, Christian König wrote: > >> Am 25.05.21 um 23:17 schrieb Jason Ekstrand: > >>> None of these helpers actually leak any RCU details to the caller. Th

Re: [Intel-gfx] [PATCH 2/7] dma-buf: Rename dma_resv helpers from _rcu to _unlocked (v2)

Am 27.05.21 um 15:25 schrieb Daniel Vetter: On Thu, May 27, 2021 at 1:59 PM Christian König wrote: Am 27.05.21 um 12:39 schrieb Daniel Vetter: On Wed, May 26, 2021 at 12:57:40PM +0200, Christian König wrote: Am 25.05.21 um 23:17 schrieb Jason Ekstrand: None of these helpers actually leak any

Re: [Intel-gfx] [PATCH 2/7] dma-buf: Rename dma_resv helpers from _rcu to _unlocked (v2)

On Thu, May 27, 2021 at 03:41:02PM +0200, Christian König wrote: > Am 27.05.21 um 15:25 schrieb Daniel Vetter: > > On Thu, May 27, 2021 at 1:59 PM Christian König > > wrote: > > > Am 27.05.21 um 12:39 schrieb Daniel Vetter: > > > > On Wed, May 26, 2021 at 12:57:40PM +0200, Christian König wrote: >

Re: [Intel-gfx] [PATCH 2/7] dma-buf: Rename dma_resv helpers from _rcu to _unlocked (v2)

Am 01.06.21 um 16:34 schrieb Daniel Vetter: On Thu, May 27, 2021 at 03:41:02PM +0200, Christian König wrote: Am 27.05.21 um 15:25 schrieb Daniel Vetter: On Thu, May 27, 2021 at 1:59 PM Christian König wrote: Am 27.05.21 um 12:39 schrieb Daniel Vetter: On Wed, May 26, 2021 at 12:57:40PM +0200

Re: [Intel-gfx] [PATCH 2/7] dma-buf: Rename dma_resv helpers from _rcu to _unlocked (v2)

Ack on all naming. -Daniel BTW As long as Jason nor you object I will prepare patches for the rename of the functions. Regards, Christian. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/i