Re: [Intel-gfx] [PATCH 2/7] drm/i915/uc: HuC firmware can't be supported without GuC

2019-08-07 Thread Michal Wajdeczko
On Wed, 07 Aug 2019 22:21:29 +0200, Kumar Valsan, Prathap wrote: On Wed, Aug 07, 2019 at 05:00:29PM +, Michal Wajdeczko wrote: There is no point in selecting HuC firmware if GuC is unsupported or it was already disabled, as we need GuC to authenticate HuC. We are calling intel_uc_ini

Re: [Intel-gfx] [PATCH 2/7] drm/i915/uc: HuC firmware can't be supported without GuC

2019-08-07 Thread Kumar Valsan, Prathap
On Wed, Aug 07, 2019 at 05:00:29PM +, Michal Wajdeczko wrote: > There is no point in selecting HuC firmware if GuC is unsupported > or it was already disabled, as we need GuC to authenticate HuC. > We are calling intel_uc_init() irrespctive of intel_uc_fetch_firmwares() is successful. Is thi

Re: [Intel-gfx] [PATCH 2/7] drm/i915/uc: HuC firmware can't be supported without GuC

2019-08-07 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-08-07 18:00:29) > There is no point in selecting HuC firmware if GuC is unsupported > or it was already disabled, as we need GuC to authenticate HuC. Makes sense. > While around, make uc_fw_init_early work without direct access > to whole i915, pass only needed plat

[Intel-gfx] [PATCH 2/7] drm/i915/uc: HuC firmware can't be supported without GuC

2019-08-07 Thread Michal Wajdeczko
There is no point in selecting HuC firmware if GuC is unsupported or it was already disabled, as we need GuC to authenticate HuC. While around, make uc_fw_init_early work without direct access to whole i915, pass only needed platform/rev info. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo