Re: [Intel-gfx] [PATCH 2/7] drm/i915: Fix computation of last_adjustment for RPS autotuning

2015-03-18 Thread Deepak S
On Wednesday 18 March 2015 02:50 PM, Chris Wilson wrote: On Wed, Mar 18, 2015 at 12:26:49PM +0530, Deepak S wrote: On Friday 06 March 2015 08:36 PM, Chris Wilson wrote: Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_irq.c | 27 --- 1 file changed, 12 in

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Fix computation of last_adjustment for RPS autotuning

2015-03-18 Thread Chris Wilson
On Wed, Mar 18, 2015 at 12:26:49PM +0530, Deepak S wrote: > > > On Friday 06 March 2015 08:36 PM, Chris Wilson wrote: > >Signed-off-by: Chris Wilson > >--- > > drivers/gpu/drm/i915/i915_irq.c | 27 --- > > 1 file changed, 12 insertions(+), 15 deletions(-) > > > >diff --g

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Fix computation of last_adjustment for RPS autotuning

2015-03-18 Thread Chris Wilson
On Wed, Mar 18, 2015 at 12:26:49PM +0530, Deepak S wrote: > On Friday 06 March 2015 08:36 PM, Chris Wilson wrote: > I think we should modify adj in GEN6_PM_RP_UP_EI_EXPIRED? > if not not we might request higher freq since we add adj to new_delay before > request freq. Oh yeah. That branch didn't

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Fix computation of last_adjustment for RPS autotuning

2015-03-18 Thread Deepak S
On Friday 06 March 2015 08:36 PM, Chris Wilson wrote: Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_irq.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 9ba

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Fix computation of last_adjustment for RPS autotuning

2015-03-06 Thread Chris Wilson
On Fri, Mar 06, 2015 at 06:32:27PM +0100, Daniel Vetter wrote: > On Fri, Mar 06, 2015 at 03:06:26PM +, Chris Wilson wrote: > > Signed-off-by: Chris Wilson > > I might have impending w/e syndrome, but I can't see what you're fixing > any more. Can you please augment the commit message a bit?

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Fix computation of last_adjustment for RPS autotuning

2015-03-06 Thread Daniel Vetter
On Fri, Mar 06, 2015 at 03:06:26PM +, Chris Wilson wrote: > Signed-off-by: Chris Wilson I might have impending w/e syndrome, but I can't see what you're fixing any more. Can you please augment the commit message a bit? Thanks, Daniel > --- > drivers/gpu/drm/i915/i915_irq.c | 27 +++

[Intel-gfx] [PATCH 2/7] drm/i915: Fix computation of last_adjustment for RPS autotuning

2015-03-06 Thread Chris Wilson
Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_irq.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 9baecb79de8c..1296ce37e435 100644 --- a/drivers/gpu/drm/i915/i9