[Intel-gfx] [PATCH 22/52] drm: Use drmm_ for drm_dev_init cleanup

2020-02-19 Thread Daniel Vetter
Well for the simple stuff at least, vblank, gem and minor cleanup I want to further split up as a demonstration. v2: We need to clear drm_device->dev otherwise the debug drm printing after our cleanup hook (e.g. in drm_manged_release) will chase released memory and result in a use-after-free. Not

Re: [Intel-gfx] [PATCH 22/52] drm: Use drmm_ for drm_dev_init cleanup

2020-02-19 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Wed, Feb 19, 2020 at 11:20:52AM +0100, Daniel Vetter wrote: > Well for the simple stuff at least, vblank, gem and minor cleanup I > want to further split up as a demonstration. > > v2: We need to clear drm_device->dev otherwise the debug drm printing > afte

Re: [Intel-gfx] [PATCH 22/52] drm: Use drmm_ for drm_dev_init cleanup

2020-02-19 Thread Daniel Vetter
On Wed, Feb 19, 2020 at 3:35 PM Laurent Pinchart wrote: > > Hi Daniel, > > Thank you for the patch. > > On Wed, Feb 19, 2020 at 11:20:52AM +0100, Daniel Vetter wrote: > > Well for the simple stuff at least, vblank, gem and minor cleanup I > > want to further split up as a demonstration. > > > > v2

Re: [Intel-gfx] [PATCH 22/52] drm: Use drmm_ for drm_dev_init cleanup

2020-02-19 Thread Laurent Pinchart
Hi Daniel, On Wed, Feb 19, 2020 at 04:27:57PM +0100, Daniel Vetter wrote: > On Wed, Feb 19, 2020 at 3:35 PM Laurent Pinchart wrote: > > On Wed, Feb 19, 2020 at 11:20:52AM +0100, Daniel Vetter wrote: > > > Well for the simple stuff at least, vblank, gem and minor cleanup I > > > want to further spl

Re: [Intel-gfx] [PATCH 22/52] drm: Use drmm_ for drm_dev_init cleanup

2020-02-19 Thread Daniel Vetter
On Wed, Feb 19, 2020 at 4:38 PM Laurent Pinchart wrote: > > Hi Daniel, > > On Wed, Feb 19, 2020 at 04:27:57PM +0100, Daniel Vetter wrote: > > On Wed, Feb 19, 2020 at 3:35 PM Laurent Pinchart wrote: > > > On Wed, Feb 19, 2020 at 11:20:52AM +0100, Daniel Vetter wrote: > > > > Well for the simple stu