Re: [Intel-gfx] [PATCH 22/57] drm/i915: Move scheduler queue

2021-02-04 Thread Chris Wilson
Quoting Tvrtko Ursulin (2021-02-04 11:19:00) > > On 01/02/2021 08:56, Chris Wilson wrote: > > @@ -252,10 +242,6 @@ struct intel_engine_execlists { > >*/ > > int queue_priority_hint; > > > > - /** > > - * @queue: queue of requests, in priority lists > > - */ > > -

Re: [Intel-gfx] [PATCH 22/57] drm/i915: Move scheduler queue

2021-02-04 Thread Chris Wilson
Quoting Tvrtko Ursulin (2021-02-04 11:19:00) > > On 01/02/2021 08:56, Chris Wilson wrote: > > bool intel_engine_is_idle(struct intel_engine_cs *engine) > > { > > + struct i915_sched *se = intel_engine_get_scheduler(engine); > > What do you have 'se' stand for? Originally i915_sched_engin

Re: [Intel-gfx] [PATCH 22/57] drm/i915: Move scheduler queue

2021-02-04 Thread Tvrtko Ursulin
On 01/02/2021 08:56, Chris Wilson wrote: Extract the scheduling queue from "execlists" into the per-engine scheduling structs, for reuse by other backends. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/gem/i915_gem_context_types.h | 2 +- drivers/gpu/drm/i915/gem/i915_gem_wait.c |

[Intel-gfx] [PATCH 22/57] drm/i915: Move scheduler queue

2021-02-01 Thread Chris Wilson
Extract the scheduling queue from "execlists" into the per-engine scheduling structs, for reuse by other backends. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/gem/i915_gem_context_types.h | 2 +- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 1 + drivers/gpu/drm/i915/gt/intel_engine_cs.