[Intel-gfx] [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-03-23 Thread Daniel Vetter
drm_mode_config_cleanup is idempotent, so no harm in calling this twice. This allows us to gradually switch drivers over by removing explicit drm_mode_config_cleanup calls. With this step it's now also possible that (at least for simple drivers) automatic resource cleanup can be done correctly

Re: [Intel-gfx] [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-03-06 Thread Sam Ravnborg
Hi Daniel. On Mon, Mar 02, 2020 at 11:26:06PM +0100, Daniel Vetter wrote: > drm_mode_config_cleanup is idempotent, so no harm in calling this > twice. This allows us to gradually switch drivers over by removing > explicit drm_mode_config_cleanup calls. > > With this step it's now also possible

[Intel-gfx] [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-03-02 Thread Daniel Vetter
drm_mode_config_cleanup is idempotent, so no harm in calling this twice. This allows us to gradually switch drivers over by removing explicit drm_mode_config_cleanup calls. With this step it's now also possible that (at least for simple drivers) automatic resource cleanup can be done correctly

Re: [Intel-gfx] [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-03-02 Thread Daniel Vetter
On Sat, Feb 29, 2020 at 12:11:28AM +0100, Daniel Vetter wrote: > On Fri, Feb 28, 2020 at 9:26 PM Sam Ravnborg wrote: > > > @@ -312,7 +305,9 @@ void drm_minor_release(struct drm_minor *minor) > > > * } > > > * drmm_add_final_kfree(drm, priv); > > > * > > > - *

Re: [Intel-gfx] [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-02-29 Thread Sam Ravnborg
Hi Daniel. > > > Also with drmm_ explicit drm_driver->release hooks are kinda not the > > > best option, so deprecate that hook to discourage future users. > > The ->release hooks has others uses until everything is moved over to > > drmm_, or so I think. So deprecation seems a lttle too soon. >

Re: [Intel-gfx] [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-02-28 Thread Daniel Vetter
On Fri, Feb 28, 2020 at 9:26 PM Sam Ravnborg wrote: > > Hi Daniel. > > Some bikeshedding in the following. > with or with addressing (IMHO valid points) consider the patch: > > Reviewed-by: Sam Ravnborg > > Sam > > On Thu, Feb 27, 2020 at 07:14:57PM +0100, Daniel Vetter wrote: > >

Re: [Intel-gfx] [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-02-28 Thread Sam Ravnborg
Hi Daniel. Some bikeshedding in the following. with or with addressing (IMHO valid points) consider the patch: Reviewed-by: Sam Ravnborg Sam On Thu, Feb 27, 2020 at 07:14:57PM +0100, Daniel Vetter wrote: > drm_mode_config_cleanup is idempotent, so no harm in calling this > twice. This

Re: [Intel-gfx] [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-02-28 Thread Thomas Zimmermann
Hi Am 28.02.20 um 09:43 schrieb Daniel Vetter: > On Fri, Feb 28, 2020 at 8:30 AM Thomas Zimmermann wrote: >> >> Hi Daniel >> >> Am 27.02.20 um 19:14 schrieb Daniel Vetter: >>> drm_mode_config_cleanup is idempotent, so no harm in calling this >>> twice. This allows us to gradually switch drivers

Re: [Intel-gfx] [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-02-28 Thread Daniel Vetter
On Fri, Feb 28, 2020 at 8:30 AM Thomas Zimmermann wrote: > > Hi Daniel > > Am 27.02.20 um 19:14 schrieb Daniel Vetter: > > drm_mode_config_cleanup is idempotent, so no harm in calling this > > twice. This allows us to gradually switch drivers over by removing > > explicit drm_mode_config_cleanup

Re: [Intel-gfx] [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-02-27 Thread Thomas Zimmermann
Hi Daniel Am 27.02.20 um 19:14 schrieb Daniel Vetter: > drm_mode_config_cleanup is idempotent, so no harm in calling this > twice. This allows us to gradually switch drivers over by removing > explicit drm_mode_config_cleanup calls. > > With this step it's not also possible that (at least for

[Intel-gfx] [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-02-27 Thread Daniel Vetter
drm_mode_config_cleanup is idempotent, so no harm in calling this twice. This allows us to gradually switch drivers over by removing explicit drm_mode_config_cleanup calls. With this step it's not also possible that (at least for simple drivers) automatic resource cleanup can be done correctly

Re: [Intel-gfx] [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-02-23 Thread Noralf Trønnes
Den 21.02.2020 22.02, skrev Daniel Vetter: > drm_mode_config_cleanup is idempotent, so no harm in calling this > twice. This allows us to gradually switch drivers over by removing > explicit drm_mode_config_cleanup calls. > > With this step it's not also possible that (at least for simple >

[Intel-gfx] [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-02-21 Thread Daniel Vetter
drm_mode_config_cleanup is idempotent, so no harm in calling this twice. This allows us to gradually switch drivers over by removing explicit drm_mode_config_cleanup calls. With this step it's not also possible that (at least for simple drivers) automatic resource cleanup can be done correctly