Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-24 Thread Mateo Lozano, Oscar
Ok, let´s try to extract something positive out of all this. OPTION A (Ben´s proposal): I think the only solution for what Chris is asking for is to implement this as 1 context per engine, as opposed to 1 context with a context object per engine. As you correctly stated, I think we all

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-24 Thread Mateo Lozano, Oscar
-Original Message- From: Volkin, Bradley D Sent: Monday, June 23, 2014 8:10 PM To: Mateo Lozano, Oscar Cc: Chris Wilson; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism On Mon, Jun 23, 2014 at 07:35:38AM

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-24 Thread Volkin, Bradley D
On Tue, Jun 24, 2014 at 04:45:05AM -0700, Mateo Lozano, Oscar wrote: Ok, let´s try to extract something positive out of all this. OPTION A (Ben´s proposal): I think the only solution for what Chris is asking for is to implement this as 1 context per engine, as opposed to 1 context

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Mateo Lozano, Oscar
-Original Message- From: Volkin, Bradley D Sent: Friday, June 20, 2014 10:01 PM To: Mateo Lozano, Oscar Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism On Fri, Jun 13, 2014 at 08:37:44AM -0700

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Chris Wilson
On Mon, Jun 23, 2014 at 01:09:37PM +, Mateo Lozano, Oscar wrote: So far, yes, but that´s only because I artificially made intel_lrc.c self-contained, as Daniel requested. What if we need to execute commands from somewhere else, like in intel_gen7_queue_flip()? And this takes me to

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Mateo Lozano, Oscar
-Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Monday, June 23, 2014 2:14 PM To: Mateo Lozano, Oscar Cc: Volkin, Bradley D; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Chris Wilson
-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism On Mon, Jun 23, 2014 at 01:09:37PM +, Mateo Lozano, Oscar wrote: So far, yes, but that´s only because I artificially made intel_lrc.c self- contained, as Daniel requested. What if we need to execute commands from

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Mateo Lozano, Oscar
-Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Monday, June 23, 2014 2:27 PM To: Mateo Lozano, Oscar Cc: Volkin, Bradley D; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Chris Wilson
Cc: Volkin, Bradley D; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism On Mon, Jun 23, 2014 at 01:09:37PM +, Mateo Lozano, Oscar wrote: So far, yes, but that´s only because I artificially made

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Mateo Lozano, Oscar
-Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Monday, June 23, 2014 2:42 PM To: Mateo Lozano, Oscar Cc: Volkin, Bradley D; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Volkin, Bradley D
Cc: Volkin, Bradley D; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism On Mon, Jun 23, 2014 at 01:18:35PM +, Mateo Lozano, Oscar wrote: -Original Message- From: Chris Wilson

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Ben Widawsky
Cc: Volkin, Bradley D; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism On Mon, Jun 23, 2014 at 01:18:35PM +, Mateo Lozano, Oscar wrote: -Original Message- From: Chris Wilson

[Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-13 Thread oscar . mateo
From: Oscar Mateo oscar.ma...@intel.com Well, new-ish: if all this code looks familiar, that's because it's a clone of the existing submission mechanism (with some modifications here and there to adapt it to LRCs and Execlists). And why did we do this? Execlists offer several advantages, like