Re: [Intel-gfx] [PATCH 3/3] drm/i915/bdw: Use the GEN8 SRM when qeueing a flip

2014-04-09 Thread Daniel Vetter
On Mon, Apr 07, 2014 at 01:59:17PM -0700, Ben Widawsky wrote: On Mon, Apr 07, 2014 at 08:24:34PM +0100, Damien Lespiau wrote: Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 22 +++--- 1 file changed, 19 insertions(+), 3

Re: [Intel-gfx] [PATCH 3/3] drm/i915/bdw: Use the GEN8 SRM when qeueing a flip

2014-04-08 Thread Chris Wilson
On Mon, Apr 07, 2014 at 11:20:14PM +0100, Damien Lespiau wrote: On Mon, Apr 07, 2014 at 01:59:17PM -0700, Ben Widawsky wrote: Cool. This explains the bad DERRMR values I was seeing in in error states. I'm honestly didn't check if we actually need an SRM for BDW still, but I'll assume you

Re: [Intel-gfx] [PATCH 3/3] drm/i915/bdw: Use the GEN8 SRM when qeueing a flip

2014-04-08 Thread Damien Lespiau
On Tue, Apr 08, 2014 at 07:24:23AM +0100, Chris Wilson wrote: On Mon, Apr 07, 2014 at 11:20:14PM +0100, Damien Lespiau wrote: On Mon, Apr 07, 2014 at 01:59:17PM -0700, Ben Widawsky wrote: Cool. This explains the bad DERRMR values I was seeing in in error states. I'm honestly didn't check

[Intel-gfx] [PATCH 3/3] drm/i915/bdw: Use the GEN8 SRM when qeueing a flip

2014-04-07 Thread Damien Lespiau
Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 3697433..a646ed4 100644

Re: [Intel-gfx] [PATCH 3/3] drm/i915/bdw: Use the GEN8 SRM when qeueing a flip

2014-04-07 Thread Damien Lespiau
On Mon, Apr 07, 2014 at 01:59:17PM -0700, Ben Widawsky wrote: Cool. This explains the bad DERRMR values I was seeing in in error states. I'm honestly didn't check if we actually need an SRM for BDW still, but I'll assume you did check. Just checked, the LRI command still mentions that we need

Re: [Intel-gfx] [PATCH 3/3] drm/i915/bdw: Use the GEN8 SRM when qeueing a flip

2014-04-07 Thread Ben Widawsky
On Mon, Apr 07, 2014 at 08:24:34PM +0100, Damien Lespiau wrote: Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c