Re: [Intel-gfx] [PATCH 3/3] drm/i915/perf: Initialize gen12 OA buffer unconditionally

2023-09-13 Thread Dixit, Ashutosh
On Tue, 12 Sep 2023 18:46:12 -0700, Umesh Nerlige Ramappa wrote: > Hi Umesh, > On Fri, Sep 08, 2023 at 06:24:16PM -0700, Dixit, Ashutosh wrote: > > On Fri, 08 Sep 2023 18:16:26 -0700, Ashutosh Dixit wrote: > >> > > > >> From: Umesh Nerlige Ramappa > >> > >> Correct values for OAR counters are

Re: [Intel-gfx] [PATCH 3/3] drm/i915/perf: Initialize gen12 OA buffer unconditionally

2023-09-12 Thread Umesh Nerlige Ramappa
On Fri, Sep 08, 2023 at 06:24:16PM -0700, Dixit, Ashutosh wrote: On Fri, 08 Sep 2023 18:16:26 -0700, Ashutosh Dixit wrote: Hi Umesh, From: Umesh Nerlige Ramappa Correct values for OAR counters are still dependent on enabling the GEN12_OAG_OACONTROL_OA_COUNTER_ENABLE in OAG_OACONTROL.

Re: [Intel-gfx] [PATCH 3/3] drm/i915/perf: Initialize gen12 OA buffer unconditionally

2023-09-08 Thread Dixit, Ashutosh
On Fri, 08 Sep 2023 18:16:26 -0700, Ashutosh Dixit wrote: > Hi Umesh, > From: Umesh Nerlige Ramappa > > Correct values for OAR counters are still dependent on enabling the > GEN12_OAG_OACONTROL_OA_COUNTER_ENABLE in OAG_OACONTROL. Enabling this > bit means OAG unit will write reports to the OAG

[Intel-gfx] [PATCH 3/3] drm/i915/perf: Initialize gen12 OA buffer unconditionally

2023-09-08 Thread Ashutosh Dixit
From: Umesh Nerlige Ramappa Correct values for OAR counters are still dependent on enabling the GEN12_OAG_OACONTROL_OA_COUNTER_ENABLE in OAG_OACONTROL. Enabling this bit means OAG unit will write reports to the OAG buffer, so initialize the OAG buffer unconditionally for all use cases. BSpec: